New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS#966 - ar71xx: images are not named to their board_names #7382
Comments
NeoRaider: Naming images after board_name is not feasible on ar71xx, as it is very common to use the same board name for different models that are the the same internally (but magic numbers in the image header differ). I agree though that the image naming could be improved. In Gluon, we use a sanitized version of /tmp/sysinfo/model for the autoupdater image selection on most targets (for an example, have a look at the TP-Link and Ubiquiti sections in https://github.com/freifunk-gluon/gluon/blob/master/targets/ar71xx-generic - the first argument of the "device" directive defines the Gluon/autoupdater image name, while the second argument is the name used by LEDE) |
lynxis: So we have:
IMHO if the image needs to be different (because of some magics), it should have it's own board_name. |
NeoRaider: Using a separate board_name for models that are basically the same hardware sounds like unnecessary code duplication in /lib/ar71xx.sh, /lib/upgrade/platform.sh, /etc/board.d/* etc. to me. How about adding a new file /tmp/sysinfo/image_name? This would default to board_name in generic code, while ar71xx and other targets could override it where necessary. Another target that uses board_name quite unusually is x86: here board_name is set to a sanitized version of the product name (as read from DMI data); this board_name is then used to identify platforms like the APU and set up LEDs etc. accordingly. So this would be another platform where deriving the image name from board_name is not possible. Note: Another reason we base our image names on /tmp/sysinfo/model instead of board_name even on platforms that have a unique board_name -> image name mapping is that the model names are easier to understand for end users, as they usually include the vendor and the full unabbreviated name of the device. |
aparcar: Hi, any news on how to handle the naming? |
adrianschmutzler: I think this discussion is obsoleted by retirement of ar71xx. Despite, I tried to achieve a similar goal when harmonizing names in ramips. |
lynxis:
Create an image using the imagebuilder (e.g. ar71xx/generic)
original reporter: aparcar
Additional reference: openwrt/asu#26 (comment)
The text was updated successfully, but these errors were encountered: