FS#935 - Modules should have default parameters as part of packaging #6249
Comments
|
pprindeville: Actually, "4" gives good performance too, giving about 1.8% better performance and lower CPU utilization (about 9%), but at the cost of slightly increased latency. |
|
ffainelli: I have a changeset here: which adds support for specifying module parameters, however after looking at it a bit more, we would have to define a syntax for specifying module parameters if there are several modules being added in an AutoLoad or AutoProbe statement, right now this changeset only works with one module as it will consider all module parameters to be relative to that module. |
|
pprindeville: Nice. In the case of a package containing multiple modules, could we prefix the parameter with "modulename:" (and strip that during the scripting)? In the case of no prefix (or a single module in the package), the parameter gets applied to all modules. |
|
pprindeville: Actually, "modulename." would be more aligned with Linux command-line handling. |
|
pprindeville: We could do something like:
for module in $modulelist; do
module_args=
for $arg in $arglist; do
case $arg in
$module.*)
module_args="$module_args ${arg#$module.}"
;;
*.*)
# ignore... not this module
;;
*)
module_args="$module_args $arg"
;;
esac
done
echo "$module$module_args" > /etc/module.d/$module
done
as a rough sketch example... |
|
ffainelli: I like this, do you want to go ahead and prepare a patch doing this? |
|
pprindeville: I can try... That's some pretty gnarly macro as it is... |
|
pprindeville: Got it mostly working, but in the case of:
AUTOLOAD:=$(call AutoProbe,e1000e,,IntMode=1 InterruptThrottleRate="4,4,4,4,4,4,4,4,4")
How does one pass a string with commas in it? |
|
pprindeville: Figured the comma question out: use $(comma) instead. |
|
pprindeville: I have a [[https://github.com/lede-project/source/pull/1274|PR #1274]] for this but it's stuck in limbo. It's neither reviewed nor merged. |
|
pprindeville: I was told to rework my PR. Jo started some work on this: which I think he intended me to use as a starting point, but it doesn't work as is. |
pprindeville:
Supply the following if possible:
I'm using the kmod-e1000e package, and I notice that it installs the file:
/etc/modules.d/e1000e
which contains:
e1000e
none of the module parameters are set. It turns out that the InterruptRateThrottling parameter can make a significant difference depending on whether your device is a client, server, or router.
In the case of LEDE/OpenWRT, one is obviously a router, and the optimal settings are not the default.
The kernel parameter:
InterruptThrottleRate="1,1,1,1,1,1,1,1"
should be added, as this gives the best results. Quoting Documentation/networking/e1000e.txt:
For situations where low latency is vital such as cluster or
grid computing, the algorithm can reduce latency even more when
InterruptThrottleRate is set to mode 1. In this mode, which operates
the same as mode 3, the InterruptThrottleRate will be increased stepwise to
70000 for traffic in class "Lowest latency".
The macro AutoProbe (and also AutoLoad) and the underlying shell scripting for probe_module() and add_module() in include/kernel.mk don't support specifying parameters.
This should be fixed.
The text was updated successfully, but these errors were encountered: