psyborg55:

fixed with

mgondium:

That's not it.
The patch
020-21-rt2800-fix-LNA-gain-assignment-for-MT7620.patch
is already in place and the problem persists (trunk).

psyborg55:

why do i even care about that

bjonglez:

pmgp: actually, this patch has been introduced between 17.01.1 and 17.01.2, so it's possibly the source of the issue rather than the fix.
The commit in question for lede-17.01 https://git.lede-project.org/?p=source.git;a=commit;h=820a39687db3b14c3264ee37548e2cac3f911bca

Could you test reverting these commits in the lede-17.01 branch (one at a time) and see which one introduces the issue?
64fa4ea
eb11207
820a396

psyborg55: please be respectful towards others, you're not being helpful.

mgondium:

Confirmed that on 17.01.0 and 17.01.1 there is no performance hit.

Reverting the patches on trunk had no effect on restoring performance. (or maybe I did it wrong? the files were indeed gone from the patches folder).
The channel number has an effect on HT40 behavior (1=slow,3=stalled).

Meanwhile, these are the unique "rt2" patches on 17.01.02 that are not on 17.01.1:

020-02-rt2x00usb-do-not-anchor-rx-and-tx-urb-s.patch
020-03-rt2x00usb-fix-anchor-initialization.patch
020-05-rt2x00-call-entry-directly-in-rt2x00_dump_frame.patch
020-06-rt2x00-remove-queue_entry-from-skbdesc.patch
020-07-rt2500usb-don-t-mark-register-accesses-as-inline.patch
020-08-rt2x00-rt2800lib-move-rt2800_drv_data-declaration-in.patch
020-09-rt2800-identify-station-based-on-status-WCID.patch
020-10-rt2x00-separte-filling-tx-status-from-rt2x00lib_txdo.patch
020-11-rt2x00-separte-clearing-entry-from-rt2x00lib_txdone.patch
020-12-rt2x00-add-txdone-nomatch-function.patch
020-13-rt2x00-fixup-fill_tx_status-for-nomatch-case.patch
020-14-rt2x00-use-txdone_nomatch-on-rt2800usb.patch
020-15-rt2800-status-based-rate-flags-for-nomatch-case.patch
020-16-rt2800-use-TXOP_BACKOFF-for-probe-frames.patch
020-17-rt2x00-fix-rt2x00debug_dump_frame-comment.patch
020-18-rt2x00-fix-TX_PWR_CFG_4-register-definition.patch

021-01-rt2800-fix-LNA-gain-assignment-for-MT7620.patch
021-02-rt2800-do-VCO-calibration-after-programming-ALC.patch
021-03-rt2800-fix-mt7620-vco-calibration-registers.patch
021-04-rt2800-fix-mt7620-E2-channel-registers.patch

I'll try to ditch them all on 17.01.2 and see how it goes.

UPDATE: Again, removing the last 4 didn't improve things, must be somewhere else.

UPDATE2:

17.01.1's
621-rt2x00-add-support-for-mt7620.patch
has become 17.01.2's
020-19-rt2x00-add-support-for-MT7620.patch
which makes removing the rest of the 020s not possible unless I remove it too and brick something.

My blunt approach is at an end here, this must be debugged by someone who understands the driver.

psyborg55:

removed

mgondium:

@psyborg55

tested just now

17.01.1: ~82/~78 Mbps dl/ul
your image: ~56 /~52 Mbps dl/ul

no errors on log and changing channels doesn't mess up like trunk
still, performance is lower

changed only the wireless configuration on your image:
config wifi-device 'radio0'
option type 'mac80211'
option hwmode '11g'
option path 'platform/10180000.wmac'
option disabled '0'
option channel '1'
option htmode 'HT40'
option txpower '20'
option country 'US'
option noscan '1'

config wifi-iface 'default_radio0'
option device 'radio0'
option network 'lan'
option mode 'ap'
option ssid ''
option hidden '1'
option encryption 'psk2+ccmp'
option key ''


psyborg55:

use same settings when doing test, especially channel.

72/85 dl/ul in my case after reverting his mess-up

mgondium:

I used the same configuration on both.

I got the same speeds from the unpatched 17.01.2 that got for your image. (~55 Mbps).
Remains to be seen where is the difference that allows 17.01.0/1 to reach 80 Mbps.

I read that the mt7620 without heatsink has a thermal throttling issue with high wifi load. I'm looking into that.

psyborg55:

removed

mgondium:

Your second image reached ~55 Mbps and remained stable.
17.01.1 got to ~70 today but becomes unstable with multiple clients. Besides the speed, those branches are not a working solution.
Trunk now reaches 50 Mbps but sometimes stalls with multiple clients.

Before testing I added a heatsink to the router's SoC, it gets quite toasty at load.

psyborg55:

trunk is not expected to have stability. performance is usually lower. my second image is trunk from about10 days ago with minor change nothing special.

on chaos calmer speed is over 100Mbps

mgondium:

Since you mentioned it, I tried the CC image and got ~75 Mbps, stable with multiple clients.

What a shame the best is in the past. It's not the first time that this LEDE/OpenWrt fork messes up radios.

mgondium:

At this point, trunk won't go past ~50 Mbps @ht40 and the radio will stall if more than one device connects to the AP (but still show on scans and allows to connect).
Changing channel requires a device restart. Issuing "wifi" just makes it freeze as above.
Ocasional "queue full" errors show up on log, as in the original report.

psyborg55:

maybe you could read dangowrt 's commit message before complaining about channel change, ha?

https://git.lede-project.org/?p=source.git;a=commit;h=9eacb9d7fc0b4c921f8d2ec91a51f10d8c3ae12f

"This makes the channel switching logic already look a bit more like
what we are used to in rt2x00.."

namidairo:

There was a bug introduced when LEDE pulled down the updated MT7260 patch from upstream mac80211 which might be causing this. Take a look at the patch linked from dangowrt's staging branch. (RT6352 was getting the wrong values set because of duplicated else if)

https://git.lede-project.org/?p=lede/dangole/staging.git;a=blob;f=package/kernel/mac80211/patches/021-rt2x00-apply-correct-TX_SW_CFG-values-for-MT7620.patch

psyborg55:

that patch as well as others regarding rt6352 are irrelevant until this trac issue is closed: https://dev.openwrt.org/ticket/22086

amir-sabbaghi:

I have found the commit that causes the drop in speed: lede-project/source@4314646
It's previous commit has more than 60Mbps throughput but after this commit drops to less than 20 Mbps.

mgondium:

@ close request
You meant, "can't be bothered"?

Archer C20i HT40
OpenWrt SNAPSHOT, r5931-b33c3e1b7c: 40 Mbps
stock: 90 Mbps

drut:

How this issue can be closed when MT7620 keeps crashing with latest releases?