Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS#866 - The DownloadMethod/hg in include/download.mk seems to be broken #6660

Closed
openwrt-bot opened this issue Jun 24, 2017 · 1 comment
Closed

FS#866 - The DownloadMethod/hg in include/download.mk seems to be broken #6660

openwrt-bot opened this issue Jun 24, 2017 · 1 comment
Labels
flyspray

Comments

@openwrt-bot
Copy link

petrn:

This is a build issue for packages which are using the Mercurial (hg) source code control system. The DownloadMethod/hg tries to re-stamp the files, but the method to do so seems insufficient.

My current fix is this one (without any claim of correctness or completeness), it allows me to make the builds as before the timestamping change was implemented.

--- a/include/download.mk
+++ b/include/download.mk
@@ -198,7 +198,7 @@ define DownloadMethod/hg
rm -rf $(SUBDIR) &&
[ ! -d $(SUBDIR) ] &&
hg clone -r $(VERSION) $(URL) $(SUBDIR) && \

  •           export TAR_TIMESTAMP=`cd $(SUBDIR) && hg log --template '@{date}' -l 1` && \

  •            export TAR_TIMESTAMP=`cd $(SUBDIR) && hg log --template '@{date}' -l 1 | cut -d'.' -f1` && \

This is with Mercurial 3.7.3 (default Mercurial in Ubuntu 16.04.2)
@openwrt-bot
Copy link
Author

jow-:

Can you provide the actual error you receive? Back when I implemented that change I explicitly tested whether GNU tar accepts epoch timestamp with fractional parts therefor I wanted to avoid the overhead of the extra cut call.

Your fix looks okay, I just like to understand the problem fully before applying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openwrt-bot