You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On LEDE 17.01 'domain' and 'local' options in dnsmasq configuration doesn't correctly support lists values as per dnsmasq capabilities.
====Steps to reproduce====
#/etc/config/dhcp
[...]
config dnsmasq
list domain 'example1.com,192.168.0.0/24'
list domain 'example2.com,192.168.1.0/24'
list local '/example1.com/'
list local '/example2.com/'
[...]
====Workaround====
Replace append_parm with config_list_foreach [[https://github.com/lede-project/source/blob/master/package/network/services/dnsmasq/files/dnsmasq.init#L816-L817|here]] resolve the issue.
I'm attaching a patch for the 17.01 dnsmasq init script but it will break old uci configuration that use 'option' instead of 'list'.
Do you have any suggestion on how to migrate old configuration and set those parameters as lists in uci web interface?
The text was updated successfully, but these errors were encountered:
It would be good to be able to override the domain for each interface. This could be done by allowing a 'domain' setting within each dhcp section, which would add a new domain= line to the dnsmasq config.
I think this would be more intuitive than the proposed change above, with the added bonus of not breaking existing configurations.
cimbalo:
On LEDE 17.01 'domain' and 'local' options in dnsmasq configuration doesn't correctly support lists values as per dnsmasq capabilities.
====Steps to reproduce====
#/etc/config/dhcp
[...]
config dnsmasq
list domain 'example1.com,192.168.0.0/24'
list domain 'example2.com,192.168.1.0/24'
list local '/example1.com/'
list local '/example2.com/'
[...]
$ uci commit dhcp
$ /etc/init.d/dnsmasq restart
====Actual results====
#/var/etc/dnsmasq.conf.cfg02411c
[...]
domain=example1.com,192.168.0.0/24 example2.com,192.168.1.0/24
local=/example1.com/ /example2.com/
[...]
====Expected results====
#/var/etc/dnsmasq.conf.cfg02411c
[...]
domain=example1.com,192.168.0.0/24
domain=example2.com,192.168.1.0/24
local=/example1.com/
local=/example2.com/
[...]
====Workaround====
Replace append_parm with config_list_foreach [[https://github.com/lede-project/source/blob/master/package/network/services/dnsmasq/files/dnsmasq.init#L816-L817|here]] resolve the issue.
I'm attaching a patch for the 17.01 dnsmasq init script but it will break old uci configuration that use 'option' instead of 'list'.
Do you have any suggestion on how to migrate old configuration and set those parameters as lists in uci web interface?
The text was updated successfully, but these errors were encountered: