OpenWrt/LEDE Project

  • Status Assigned
  • Percent Complete
  • Task Type Bug Report
  • Category Base system
  • Assigned To
    Hans Dedecker
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by cimbalo - 18.06.2017

FS#853 - Change dnsmasq domain and local options to lists

On LEDE 17.01 ‘domain’ and ‘local’ options in dnsmasq configuration doesn’t correctly support lists values as per dnsmasq capabilities.

Steps to reproduce

config dnsmasq
        list domain ','
        list domain ','
        list local '/'
        list local '/'

$ uci commit dhcp
$ /etc/init.d/dnsmasq restart

Actual results

local=/ /

Expected results



Replace append_parm with config_list_foreach here resolve the issue.
I’m attaching a patch for the 17.01 dnsmasq init script but it will break old uci configuration that use ‘option’ instead of ‘list’.
Do you have any suggestion on how to migrate old configuration and set those parameters as lists in uci web interface?

Jo-Philipp Wich commented on 23.06.2017 12:49

This patch will break LuCI support if applied as-is, please keep in mind to update LuCI as well if you're going to merge it.

Hamish Moffatt commented on 18.04.2021 03:22

It would be good to be able to override the domain for each interface. This could be done by allowing a 'domain' setting within each dhcp section, which would add a new domain= line to the dnsmasq config.

I think this would be more intuitive than the proposed change above, with the added bonus of not breaking existing configurations.


Available keyboard shortcuts


Task Details

Task Editing