Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#792 - Reset button not working on Linksys WRT54GSv1 #5551

Closed
openwrt-bot opened this issue May 17, 2017 · 0 comments
Closed

FS#792 - Reset button not working on Linksys WRT54GSv1 #5551

openwrt-bot opened this issue May 17, 2017 · 0 comments
Labels

Comments

@openwrt-bot
Copy link

mpa:

Pressing the Reset button has no effect on the Linksys WRT54GSv1.

A short press should cause the device to reboot, and a long press should cause a factory reset. With the following script added, there should be a log entry for each button press and release:

root@LEDE:~# cat /etc/hotplug.d/button/buttons
#!/bin/sh
logger "button $BUTTON $ACTION"

None of these effects can be observed on the Linksys WRT54GSv1, running either the LEDE master branch or the 17.01.1 release.

This is caused by a resource conflict for GPIO 6, which is claimed by both the adm6996 switch driver and the gpio_button_hotplug kernel module.

gpio-keys gpio-keys.0: unable to claim gpio 6, err=-16
gpio-keys: probe of gpio-keys.0 failed with error -16

After unbinding the switch driver:

echo adm6996_gpio > /sys/bus/platform/drivers/adm6996_gpio/unbind

the gpio_button_hotplug module can be loaded without error, and the Reset button works.

The switch driver requests this GPIO for the switch chip's RC pin, but never uses it, so it can be safely disabled.

I could come up with two possible solutions: replace the nvram entry gpio6=adm_rc to point to an unused GPIO, or patch the switch driver to not request the adm_eerc GPIO. I consider the nvram modification more risky and prefer the latter solution. What do you think?

Regards,
Mirko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant