You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The recent addition of "Alternatives" support seems to break "ip" symlink if only "tc" is selected from the iproute2 package. That will make /sbin/ip to point into non-existent /sbin/ip-full. That will make "ip" non-functional, breaking all packages that use "ip" command, inlucding SQM, BCP38 and various others.
I have selected in my config only "tc" from iproute2, but not ip-tiny or ip-full. Busybox ip is enough for me. This will be the case for all basic SQM users, so this will hit users in large scale.
When debugging firewall I noticed an "ip" error and started to investigate. Then I noticed that my system had a faulty symlink to ip-full although that is not installed:
root@LEDE:~# ls -l /sbin/ip
lrwxrwxrwx 1 root root 13 May 2 19:16 /sbin/ip -> /sbin/ip-full
After some compilation testing with minimal firmware (no additional packages), I have noticed that:
compiling from dac629f is still ok ("ip" symlink to /bin/busybox)
compiling from 9b4c415 is ok, if tc is built but not installed ("m").
compiling from 9b4c415 generates the wrong symlink, if tc is installed ("y").
I looked into the compiled tc .ipk and noticed that for some reason the Alternatives definition for "ip" gets also included in "tc" package .ipk:
Looking at the iproute2 Makefile it is not obvious to me why that happens. The Alternatives definitions are in the ip-tiny and ip-full definitions, so they should not wander into "tc". Likely the script parsing the Alternatives for ipk inclusion is faulty somehow.
The text was updated successfully, but these errors were encountered:
hnyman:
The recent addition of "Alternatives" support seems to break "ip" symlink if only "tc" is selected from the iproute2 package. That will make /sbin/ip to point into non-existent /sbin/ip-full. That will make "ip" non-functional, breaking all packages that use "ip" command, inlucding SQM, BCP38 and various others.
I have selected in my config only "tc" from iproute2, but not ip-tiny or ip-full. Busybox ip is enough for me. This will be the case for all basic SQM users, so this will hit users in large scale.
When debugging firewall I noticed an "ip" error and started to investigate. Then I noticed that my system had a faulty symlink to ip-full although that is not installed:
root@LEDE:~# ls -l /sbin/ip lrwxrwxrwx 1 root root 13 May 2 19:16 /sbin/ip -> /sbin/ip-full
After some compilation testing with minimal firmware (no additional packages), I have noticed that:
I looked into the compiled tc .ipk and noticed that for some reason the Alternatives definition for "ip" gets also included in "tc" package .ipk:
control file from .ipk:
Package: tc Version: 4.4.0-10 Depends: libc, kmod-sched-core Alternatives: 300:/sbin/ip:/sbin/ip-full Source: package/network/utils/iproute2 ...
Looking at the iproute2 Makefile it is not obvious to me why that happens. The Alternatives definitions are in the ip-tiny and ip-full definitions, so they should not wander into "tc". Likely the script parsing the Alternatives for ipk inclusion is faulty somehow.
The text was updated successfully, but these errors were encountered: