OpenWrt/LEDE Project

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Packages
  • Assigned To
    Rafał Miłecki
  • Operating System All
  • Severity Very Low
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by Nathaniel Wesley Filardo - 27.03.2017
Last edited by Jo-Philipp Wich - 01.06.2017

FS#658 - umdns init error during build

During a build of LEDE HEAD as of right now (git describe says reboot-3906-g2a2dfb2be7), with umdns selected, during some post-configuration phase, the umdns init file is invoked and promptly fails with “.../etc/init.d/umdns: line 4: /lib/functions/network.sh: No such file or directory”, as expected on a build machine that isn’t itself running LEDE/OpenWRT.

For context, here’s the surrounding lines of the build:

Configuring collectd-mod-df.
Configuring kmod-ledtrig-netdev.
Setting flags for package libc to hold.
Setting flags for package libgcc to hold.
Setting flags for package libpthread to hold.
Setting flags for package librt to hold.
make[3]: Entering directory '/tank/openwrt/scratch/builder-webserver'
make[3]: Nothing to be done for 'package/preconfig'.
make[3]: Leaving directory '/tank/openwrt/scratch/builder-webserver'
cp -fpR /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root.orig-kirkwood
/tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/etc/init.d/umdns: line 4: /lib/functions/network.sh: No such file or directory
./etc/init.d/umdns: line 4: /lib/functions/network.sh: No such file or directory
sed -i "s/Installed-Time: .*/Installed-Time: 1490645168/" /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/status
rm -f /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/lists/*
rm -f /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/info/*.postinst*
rm -f /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/info/*.prerm*
make[2]: Leaving directory '/tank/openwrt/scratch/builder-webserver'
Closed by  Jo-Philipp Wich
01.06.2017 23:30
Reason for closing:  Fixed
Additional comments about closing:  

Fixed with http://git.lede-project.org/6db1d 13084

Project Manager
Florian Fainelli commented on 27.03.2017 23:32

Proposed fix:

diff --git a/package/network/services/umdns/files/umdns.init b/package/network/services/umdns/files/umdns.init
index 627930b88d7f..43ff88d3d9cd 100644
--- a/package/network/services/umdns/files/umdns.init
+++ b/package/network/services/umdns/files/umdns.init
@@ -1,8 +1,6 @@
 #!/bin/sh /etc/rc.common
 # Copyright (c) 2014 OpenWrt.org
 
-. /lib/functions/network.sh
-
 START=80
 
 USE_PROCD=1
@@ -31,6 +29,8 @@ reload_service() {
 }
 
 start_service() {
+       . /lib/functions/network.sh
+
        local network="$(uci get umdns.@umdns[-1].network)"
 
        procd_open_instance

Nathaniel Wesley Filardo commented on 28.03.2017 03:27

Sorry; the git commit mentioned includes some of my (unrelated) patches; upstream is reboot-3883-g2ebfdabfbd.

That patch seems like it will do the right thing by me, but I am confused as to why the init scripts are run at all, really.

Project Manager
Rafał Miłecki commented on 28.03.2017 04:53
I am confused as to why the init scripts are run at all, really.

Same here. I don't think this fix should be needed. For me umdns builds fine, buildbots also don't complain. What's the output of

./scripts/diffconfig.sh

in your setup?

Nathaniel Wesley Filardo commented on 30.03.2017 06:50

diffconfig output attached.

Project Manager
Rafał Miłecki commented on 30.03.2017 07:38

Your config uses ar71xx target:
CONFIG_TARGET_ar71xx=y

But the failing log comes from kirkwood target.

What's going on there?

Nathaniel Wesley Filardo commented on 30.03.2017 17:56

Gah, I spaced out and ran diffconfig in the wrong directory. I'm so sorry for the noise; here's the right one.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing