Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#609 - procd: implement runlevel 1 #9104

Open
openwrt-bot opened this issue Mar 9, 2017 · 1 comment
Open

FS#609 - procd: implement runlevel 1 #9104

openwrt-bot opened this issue Mar 9, 2017 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

stintel:

Sysupgrade currently kills processes with SIGKILL if they don't shut down within 3 seconds after the SIGTERM signal. Some processes (e.g. domoticz) can take longer than 3 seconds to properly shut down. As this can potentially corrupt the sqlite database, it should be avoided.

While talking about this on IRC, it was suggested we should implement an "init 1" equivalent in procd. Adding this ticket as a reminder.

@openwrt-bot
Copy link
Author

stintel:

https://git.openwrt.org/87b583635475c56ae5b8ec89233f6f292ba09765 implements this for the sysupgrade case. I will investigate if it makes sense to add it to the shutdown/reboot case:

diff --git a/state.c b/state.c index fb81248..bf7557f 100644 --- a/state.c +++ b/state.c @@ -224,6 +224,7 @@ void procd_shutdown(int event) if (state >= STATE_SHUTDOWN) return; DEBUG(2, "Shutting down system with event %x\n", event); + service_stop_all(); reboot_event = event; state = STATE_SHUTDOWN; state_enter();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant