Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#590 - ImageBuilder ar71xx BIN_DIR issue #6376

Closed
openwrt-bot opened this issue Mar 3, 2017 · 2 comments
Closed

FS#590 - ImageBuilder ar71xx BIN_DIR issue #6376

openwrt-bot opened this issue Mar 3, 2017 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

nemesisdesign:

Software versions of LEDE release: lede 17 branch

Steps to reproduce:

  • compile ar71xx with image builder support from lede 17 branch
  • use the imagebuilder like: make image BIN_DIR=/var/www/downoads

we started testing lede-17.01 for [[http://openwisp.org|OpenWISP.org]] and we noticed a
strange issue with the image-generator.

We supply a command like:

make image PROFILE="Default" BIN_DIR="$BIN_DIR"

but the image building fails because something goes to look for binaries
in ./bin/targets/ar71xx/generic instead of
"$BIN_DIR/targets/ar71xx/generic".

If we create manually the dir with:

mkdir ./bin/targets/ar71xx/generic

The image building procedure completes successfully.

Is this desired behaviour or not?

We had to insert a workaround in our [[https://github.com/openwisp/ansible-openwisp2-imagegenerator/commit/be8602dff0e4892a7206618a3e3dba9b5154eee7|automated LEDE compilation process]].

@openwrt-bot
Copy link
Author

andrenarchy:

We observed the same issue at Freifunk Berlin. When BIN_DIR is provided, some profiles work while others don't. Without BIN_DIR, everything works as expected. As an example, the following command does not work:

$ make image PROFILE=DIR505A1 PACKAGES="-ppp -ppp-mod-pppoe" BIN_DIR="/tmp/images" [...] bash: /tmp/freifunk-berlin-imagebuilder-1.0.0-alpha-ar71xx-generic.Linux-x86_64/bin/targets/ar71xx/generic/freifunk-berlin-1.0.0-alpha-ar71xx-generic-dir-505-a1-squashfs-sysupgrade.bin: No such file or directory [...]

@openwrt-bot
Copy link
Author

jow-:

It likely affects all profiles using legacy image build code. Can you please try this diff?

diff --git a/include/image.mk b/include/image.mk
index 3f5b4544e9..8b7569817a 100644
--- a/include/image.mk
+++ b/include/image.mk
@@ -568,7 +568,7 @@ define BuildImage

legacy-images-make: install-images
$(call Image/mkfs/ubifs/legacy)

  •   $(MAKE) legacy-images
    
  •   $(MAKE) legacy-images BIN_DIR="$(BIN_DIR)"
    

    install: install-images
    $(call Image/Manifest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant