OpenWrt/LEDE Project

  • Status New
  • Percent Complete
    0%
  • Task Type Bug Report
  • Category Base system
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Medium
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by stefanct - 13.07.2016
Last edited by Adrian Schmutzler - 03.02.2020

FS#50 - No image or non-verbose output created if image is too big

The target/install target does not produce the *squashfs-factory.bin and *squashfs-sysupgrade.bin binaries if the images are too big to fit the selected flash size.
However, make doesn’t say a word to the user but simply does not produce the files. The user has to either check the mtime of the files if they were created earlier or use

make target/install V=s

to derive what’s wrong.
According to jow on IRC this is just an artifact of no way to bypass silent mode. That might be the common explanation but it is still a bug from my POV.

lemoer commented on 03.03.2017 15:04

I would also like to see this fixed, because it's very annoying to spend hours in debugging elsewhere because the build was "successful".

In my opinion, the priority should be changed a little higher than "very low". ;)

Hannu Nyman commented on 03.03.2017 16:13

It might be finally possible to "fix" this, the there is now the separate CONFIG_BUILDBOT symbol in LEDE.

In buildbot the build needs to fail silently and the build should continue, as the other images from the same target need to be built, even if one router fails.

But I guess that in private builds (when CONFIG_BUILDBOT is not set), the failure might be seen as more fatal and could stop the build process.

The silently failing builds due to "too big" has been a frequent topic in forums, so fixing this might help a lot of people.

lemoer commented on 03.03.2017 17:36

I think it would be better to introduce a state "image failed", where the build process continues building other images and targets. At the end of the build process, it should print:

The following images have failed:
- ar71xx-generic
    - TP-Link TL-WR841N/ND v11 (images are too big by 53912 bytes)
    - ...
- ...

and exit with unclean exit code.

Urja Rannikko commented on 03.02.2020 16:45

Poke. I also think this should have some priority that is higher than "Very Low", because this caused long confusion in my work - i thought i hadnt turned on a knob necessary to make the factory & sysupgrade images, but instead they were just too big and not made...

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing