New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS#451 - ipq806x: random mac is assigned to WiFi phys #5495
Comments
mkresin: Hey Pavel, am I right that it worked for you back in the days? If yes, any chance that you do a git bisect to check which commit introduced the issue? I can not see something obvious wrong and don't have a ipq806x board to test it on my own. |
hnyman: It seems to have broken down in January 2017, before 22th. I tested with my R7800 my archive of month-end builds, and: MAC ok: r2708-39d3a4117b-20161230 I will look for suspicious changes between r2708 and r3064... |
hnyman: Looks like it is the commit 71a39b8 Specifically the change to 10_fix_wifi_mac script. I tested with a live R7800 running up-to-date r3285-1a52d11d38
Possibly some sneaky whitespace error, or such. EDIT: |
mkresin: Wow, I had never expected that a trailing tab can cause such issues. Hannu, would it be possible that you send a patch that references this bugreport. |
hnyman: Pull request submitted as Note that the patch is needed also for 17.01. |
hnyman:
That surprised also me, but it is actually perfectly logical (as then the TAB is the next char to be ignored, not the subsequent newline). That seems to be also mentioned in some shell script resources: For example:
|
dissent1:
Noticed on C2600 and R7800, probably others are affected as well.
Mac address on ipq806x targets is assigned by https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/ipq806x/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
This script doesn't seem to trigger, because wifi phys get random mac addresses.
The text was updated successfully, but these errors were encountered: