New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS#446 - usbport trigger: The default configuration for all families should be changed from usbdev to usbport #8186
Comments
mkresin: I agree with you that ucidef_set_led_usbdev should be replaced with ucidef_set_led_usbport. Patches are welcome! |
mkresin: Moving the discussion in FS#454 to the correct ticket:
If you are really talking about this ticket, you are reading words that are not written. I've confirmed that it should be changed. And I would like to see that //anyone// sends a patch to fix it. I don't know if you aware that all devs are doing the development in their free time and without getting paid by the LEDE project. The only difference between you and us is that we have commit access.
I'm not sure if I got you right. Are your really saying that you have not enough time to fix "trivial things like usbdev to usbport or reordering lan ports" and you expect that it gets fixed by the devs in their free time and for free? |
howl: Have done a pull request (#1819) but I have doubts how usbport trigger handle usbdev configurations like "1-1.1". I could do it as "usb1-port1.1" but don't know if that could break the trigger setup due to usbport behaviour. If someone with a tl-wdr4300, tl-wr942n-v1 or arduino-yun could check how usbport defines that port configurations whould be great to change all the usbdev to usbport triggers. The PR actually changes all the boards except tl-wdr4300, tl-wr942n-v1 and arduino-yun. |
howl: This can be closed, the PR was merged. |
howl:
Recently LuCI has get ability to configure LED's with the usbport trigger openwrt/luci#971. There are issues when reading the old usbdev trigger. There is no need to stay with usbdev at all so if it's possible it should be converted to use usbport.
The text was updated successfully, but these errors were encountered: