Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#446 - usbport trigger: The default configuration for all families should be changed from usbdev to usbport #8186

Closed
openwrt-bot opened this issue Jan 31, 2017 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

howl:

Recently LuCI has get ability to configure LED's with the usbport trigger openwrt/luci#971. There are issues when reading the old usbdev trigger. There is no need to stay with usbdev at all so if it's possible it should be converted to use usbport.

@openwrt-bot
Copy link
Author

mkresin:

I agree with you that ucidef_set_led_usbdev should be replaced with ucidef_set_led_usbport. Patches are welcome!

@openwrt-bot
Copy link
Author

mkresin:

Moving the discussion in FS#454 to the correct ticket:

Anyways reading also this bug report https://bugs.lede-project.org/index.php?do=details&task_id=446&opened=335&type%5B0%5D=&sev%5B0%5D=&due%5B0%5D=&cat%5B0%5D=&status%5B0%5D=open&percent%5B0%5D=&reported%5B0%5D= seems that my reports are ¿disturbing? you, and I don't know why. Even if I know how to do patches or not, or I have time or not, or whatever, doesn't mind for bug reporting. If only people who provide code can report bugs just tell me and I stop right now.

If you are really talking about this ticket, you are reading words that are not written. I've confirmed that it should be changed. And I would like to see that //anyone// sends a patch to fix it.

I don't know if you aware that all devs are doing the development in their free time and without getting paid by the LEDE project. The only difference between you and us is that we have commit access.

But let me add two last things just to answer you with facts when you are treating as a stupid, opportunist or freeloader, or the three at the same time:

1.- At least in my situation is lack of time, if I had time, before changing trivial things like usbdev to usbport or reordering lan ports.

I'm not sure if I got you right. Are your really saying that you have not enough time to fix "trivial things like usbdev to usbport or reordering lan ports" and you expect that it gets fixed by the devs in their free time and for free?

@openwrt-bot
Copy link
Author

howl:

Have done a pull request (#1819) but I have doubts how usbport trigger handle usbdev configurations like "1-1.1". I could do it as "usb1-port1.1" but don't know if that could break the trigger setup due to usbport behaviour. If someone with a tl-wdr4300, tl-wr942n-v1 or arduino-yun could check how usbport defines that port configurations whould be great to change all the usbdev to usbport triggers.

The PR actually changes all the boards except tl-wdr4300, tl-wr942n-v1 and arduino-yun.

@openwrt-bot
Copy link
Author

howl:

This can be closed, the PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant