OpenWrt/LEDE Project

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Bug Report
  • Category Base system
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by Luiz Angelo Daros de Luca - 22.11.2021

FS#4150 - ./script/feeds does not return error on failure

Hello,

Script feeds always returns 0, no matter if it did what it was asked to or not

$ ./scripts/feeds install foobar && echo ok || echo err
WARNING: No feed for package 'foobar' found
ok


Hannu Nyman commented on 27.11.2021 12:19
Script feeds always returns 0

Not quite true.
The return value logic depends on the command used. For example, the "update" command was patched by me in 2015 to provide an error on failed feed updates.

Based on the source code, also the package install step usually provides an error code, with the exception of the case that you encountered: no feed found. Then there is plain "return 0" despite the error condition.

https://github.com/openwrt/openwrt/blob/master/scripts/feeds#L597-L613

(The same situation seems to be with the subfunction install_src: https://github.com/openwrt/openwrt/blob/master/scripts/feeds#L523-L524 )

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing