Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#409 - Archer C7 all leds are green #7338

Closed
openwrt-bot opened this issue Jan 19, 2017 · 6 comments
Closed

FS#409 - Archer C7 all leds are green #7338

openwrt-bot opened this issue Jan 19, 2017 · 6 comments
Labels

Comments

@openwrt-bot
Copy link

howl:

In Archer C7 all leds are green but in lede only the usb leds are labeled as green, all the rest ones are labeled as blue.

@openwrt-bot
Copy link
Author

mkresin:

I had to revert my commit. It was incomplete and the issues isn't that easy fixable.

@openwrt-bot
Copy link
Author

howl:

Let me copy your commit comment for better understanding (I used code block because can't find quote at least in the icons above):

Revert "ar71xx: fix Archer C7 LED colour names"

This reverts commit e79ecb4c26471526552d2473bb50d331c3dafb87.

The commit was incomplete and the issue that should be fixed isn't
that easy fixable. The Archer C7 mach file is used for the Archer C5,
WDR4900 and WDR7500 as well. Where the WDRs in compare to the Archer
do have blue LEDs.

I see, I didn't think about it despite I know the WDR7500. I didn' thought that the same dts is used for these devices.

It could be interesting then to have a common dts file and the include per specific device with the little changes they have. I know that the led colors is just a little thing but there is also modded WDR7500 where the flash chip (8 MiB) is changed with the one found in the Archer C7 (16 MiB) and then the LEDE Archer C7 firmware gets flashed showing Archer C7 as model. If there are separated definitions it could be possible to add for example one for that use case showing something like TP-Link WDR7500 (16 MiB mod).

@openwrt-bot
Copy link
Author

mkresin:

That is more or less what I'm thinking about to do. But the ar71xx target doesn't have device tree support yet. Therefore, no dts files and no dtsi files which could be included.

Switching ar71xx to the device tree is in preparation and as soon as it is done I will have look at it again.

@openwrt-bot
Copy link
Author

howl:

Thanks for your comment Mathias, I was thinking in the lantiq family but I now see how differs one from another. If I understand you right I suppose that device tree way is how for example lantiq is implemented.

@openwrt-bot
Copy link
Author

JamesT42:

TP-Link changed the LED color I believe from C7 V1 to V2. But this is only a small problem I think.

@openwrt-bot
Copy link
Author

howl:

This seems that as Mathias said it's going to be fixed in ath79, hope that it can be released for the next stable version. Thanks for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant