Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3846 - ppp-multilink in build system cannot replace ppp, but can also not installed at the same time. #8854

Open
openwrt-bot opened this issue Jun 3, 2021 · 1 comment
Labels
flyspray release/21.02 pull request/issue targeted (also) for OpenWrt 21.02 release

Comments

@openwrt-bot
Copy link

dreieck:

PACKAGE_ppp-multilink seems to provide the ppp-daemon with added multilink functionality. So it should be possible to select ppp-multilink instead of ppp. But in the configuration system the dependencies are not set that way.

If some package required ppp, it still cannot be unselected if ppp-multilink is selected (see attached screenshot), as it is with many other packages where there are alternatives for the same functionality. Furthermore, PACKAGE_ppp-multilink=y will produce a clash with PACKAGE_ppp=y when it comes to the install step, see [[/index.php?do=details&task_id=3845|Task #3845]].

ppp has as Selected by-dependencies:

Selected by [y]: - PACKAGE_modemmanager [=y] - PACKAGE_pppossh [=y] && (PACKAGE_dropbear [=y] || PACKAGE_openssh-client [=n]) Selected by [m]: - PACKAGE_openfortivpn [=m] - PACKAGE_sstp-client [=m] Selected by [n]: - MODULE_DEFAULT_ppp [=n] && TARGET_PER_DEVICE_ROOTFS [=n] && m && MODULES [=y] - PACKAGE_rp-pppoe-sniff [=n] && BROKEN [=n] - PACKAGE_pptpd [=n]

where PACKAGE_ppp-multilink has none at all.

As Selects-dependency, they both have (in different order, but same items):
Selects: PACKAGE_kmod-ppp [=y] && PACKAGE_libc [=y] && PACKAGE_librt [=y] && PACKAGE_libpthread [=y]

@openwrt-bot
Copy link
Author

dreieck:

The URL above is wrong, it happened due to auto-prepending stuff to a relative URL, see [[https://bugs.openwrt.org/index.php?do=details&task_id=3848|Task #3848]].

The correct URL is [[https://bugs.openwrt.org/index.php?do=details&task_id=3845|this one]].

Also, the attached file got missing, maybe due to the thing described in [[https://bugs.openwrt.org/index.php?do=details&task_id=3847|Task #3847]]. I re-attach it here. Fot the resons described in [[https://bugs.openwrt.org/index.php?do=details&task_id=3847|Task #3847]] this task also has no tags.

@aparcar aparcar added the release/21.02 pull request/issue targeted (also) for OpenWrt 21.02 release label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/21.02 pull request/issue targeted (also) for OpenWrt 21.02 release
Projects
None yet
Development

No branches or pull requests

2 participants