Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3721 - custom "CONFIG_VERSION_DIST" breaks building Edimax images #8746

Open
openwrt-bot opened this issue Apr 2, 2021 · 0 comments
Open
Labels

Comments

@openwrt-bot
Copy link

SAm0815:

Just ran a custom build for ath79 with setting CONFIG_VERSION_DIST="Roederer" finally fails in target/linux/install with

/mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/staging_dir/host/bin/edimax_fw_header -M F9J1108v1 -m BR-6679BAC -v Roedererr15865 -n "uImage" -i /mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/loader-belkin_f9j1108-v2.uImage -o /mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/tmp/roederer-2021.04-1faf8bcb-ath79-generic-belkin_f9j1108-v2-squashfs-factory.bin.uImage [edimax_fw_header] *** error: 'Roedererr15865' is too long, max firware version length is 13 Makefile:87: recipe for target '/mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/tmp/roederer-2021.04-1faf8bcb-ath79-generic-belkin_f9j1108-v2-squashfs-factory.bin' failed make[5]: *** [/mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/tmp/roederer-2021.04-1faf8bcb-ath79-generic-belkin_f9j1108-v2-squashfs-factory.bin] Error 255

So the VERSION_DIST gets suffixed by "r15865" which make it 14 bytes long. With the default "OpenWrt" it will be excatly 13 bytes.

Not sure what's the best fix:

  • limiting the max length of the CONFIG-option
  • stripping something from the vesion-string provided to the edimax_fw_header command
  • chopping the extra bytes

This was actually seen in OpenWrt-21.02, but the Makefile seems identical to master.
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ath79/image/generic.mk;h=f358d44064438c2aad4cf45840dee40f5381b2fe;hb=refs/heads/master#l55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant