Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3719 - Openwrt image builder instructions for FILES_REMOVE parameter don't seem to work any more. #8745

Closed
openwrt-bot opened this issue Apr 2, 2021 · 1 comment
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release

Comments

@openwrt-bot
Copy link

bifferos:

I'm attempting to use the x86 image builder for 19.07.7
https://downloads.openwrt.org/releases/19.07.7/targets/x86/64/openwrt-imagebuilder-19.07.7-x86-64.Linux-x86_64.tar.xz

There are some instructions in the documentation at:
https://openwrt.org/docs/guide-user/additional-software/imagebuilder

They say to patch the makefile:

ifneq ($(USER_FILES),)
$(MAKE) copy_files
endif
+
+ifneq ($(FILES_REMOVE),)

  • @echo
  • @echo Remove useless files
  • while read filename; do \
  •   rm -rfv "$(TARGET_DIR)$$filename";	\
    
  • done < $(FILES_REMOVE);
    +endif
  • $(MAKE) package_postinst
    $(MAKE) build_image

But the Makefile layout seems to have changed since the instructions were written so it isn't clear where to add this.

This is a really handy feature, so I hope the developers will eventually include this to avoid the need to patch the makefile.

@aparcar aparcar added the release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release label Feb 22, 2022
@ynezz
Copy link
Member

ynezz commented May 24, 2022

OpenWrt 19.07 release is EOL, try to reproduce the issue with latest supported release and feel free to ask for issue reopening if the problem is still present, thanks.

@ynezz ynezz closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release
Projects
None yet
Development

No branches or pull requests

3 participants