Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS#365 - Build failure - missing dependency in hostapd Makefile #5461

Closed
openwrt-bot opened this issue Jan 4, 2017 · 5 comments
Closed

FS#365 - Build failure - missing dependency in hostapd Makefile #5461

openwrt-bot opened this issue Jan 4, 2017 · 5 comments
Labels
flyspray

Comments

@openwrt-bot
Copy link

synnack:

There is a missing dependency when eapol_test is being built (useful for testing connectivity to the RADIUS servers).
It currently results in a build failure in the main repository.

The following patch fixes it:

diff --git a/package/network/services/hostapd/Makefile b/package/network/services/hostapd/Makefile
index 207dfec..de53dd8 100644
--- a/package/network/services/hostapd/Makefile
+++ b/package/network/services/hostapd/Makefile
@@ -242,7 +242,7 @@ define Package/eapol-test
SECTION:=net
CATEGORY:=Network
VARIANT:=supplicant-full

  • DEPENDS:=$(DRV_DEPENDS)
  • DEPENDS:=$(DRV_DEPENDS) +WPA_SUPPLICANT_OPENSSL:libopenssl
    endef
@openwrt-bot
Copy link
Author

synnack:

Wow, that messes a lot with formatting.. attaching patch as separate file.

@openwrt-bot
Copy link
Author

mkresin:

Hey Wilco,

please don't use the bugtracker to submit patches. Follow the steps outlined in [[https://lede-project.org/docs/guide-developer/the-source-code#submitting_patches|submitting patches]].

@openwrt-bot
Copy link
Author

synnack:

I'm confused. I should not create a bug report for a defect?
Or not if I plan to attach a patch which fixes it?

In any case, here is the pull request.

lede-project/source#685

@openwrt-bot
Copy link
Author

mkresin:

If you have a patch, send the patch the way you have done it now. It doesn't make much sense to me to open a bug and providing the fix at the same time. Better submit the fix the "official" way.

The bugtracker is for reporting bugs and we do not pick patches from the bugtracker.

@openwrt-bot
Copy link
Author

bjonglez:

Fixed with https://git.lede-project.org/?p=source.git;a=commit;h=fa0ac030f538448fcb3e4aac5d158128e9df9560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openwrt-bot