Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS#3580 - [mvebu] duplicate device entries #8614

Closed
openwrt-bot opened this issue Jan 20, 2021 · 6 comments
Closed

FS#3580 - [mvebu] duplicate device entries #8614

openwrt-bot opened this issue Jan 20, 2021 · 6 comments
Labels
flyspray

Comments

@openwrt-bot
Copy link

mwarning:

in the "make menuconfig" menu, the duplicate devices are shown for all devices that have alternative names.
If one entry to selected, the one for the alternative device is also selected.

This happens on the OpenWrt master branch.

                    │  Use the arrow keys to navigate this window or press the      │  
                    │  hotkey of the item you wish to select followed by the <SPACE │  
                    │  BAR>. Press <?> for additional information about this        │  
                    │ ┌────^(-)───────────────────────────────────────────────────┐ │  
                    │ │( ) Linksys WRT1900AC v1                                   │ │  
                    │ │( ) Linksys Cobra (Linksys WRT1900AC v2)                   │ │  
                    │ │( ) Linksys WRT1900AC v2                                   │ │  
                    │ │(X) Linksys Rango (Linksys WRT3200ACM)                     │ │  
                    │ │(X) Linksys WRT3200ACM                                     │ │  
                    │ │( ) Linksys Venom (Linksys WRT32X)                         │ │  
                    │ └────v(+)───────────────────────────────────────────────────┘ │  
                    ├───────────────────────────────────────────────────────────────┤  
                    │                    <Select>      < Help >                     │
@openwrt-bot
Copy link
Author

mwarning:

Reported here: https://forum.openwrt.org/t/problem-during-my-image-build/85982/24

@openwrt-bot
Copy link
Author

mwarning:

Expected would be a single entry called "Linksys WRT3200ACM (Linksys Rango)"

@openwrt-bot
Copy link
Author

mwarning:

This phenomena also appears for other targets.

@openwrt-bot
Copy link
Author

adrianschmutzler:

This is expected behavior. The point is to provide an entry at different positions if the device has different names. So, a user looking for "a-vendor device" and a user looking for "z-vendor device" will both find the device at the spot they are looking to.
But since it's all the same device, all aliases are shown as selected.

@openwrt-bot
Copy link
Author

kaloz:

As per the created ticket, no, it's not the expected behavior from the users' side. The whole answer is false given you can see the model number in both “vendor and z-vendor” variants - this change is among the pitying and outsmarting users series of contributions.

@openwrt-bot
Copy link
Author

adrianschmutzler:

I really don't see why providing additional information is a problem. Not every user will be as smart as you are and immediately know the correct name we are using.

As for changes, of course we can just remove all these alternative names again, and just have one name per device in 'make menuconfig' and metadata, like we do have only one image per device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openwrt-bot