Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3498 - Reset button is not working due to define reset button as wps button #8522

Closed
openwrt-bot opened this issue Dec 9, 2020 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

Human-OS:

-In TP-LINK tl-mr3220 v2 reset is button not working.

-In files /target/linux/ar71xx/files/arch/mips/mach-tl-wr741nd-v4.c the wifi button of tl-
mr3220-v2 is defined as wps button.As a result reset button is not working.

-to fix this we need to do following patch :

 --#define TL_MR3220V2_GPIO_BTN_WPS 	11
 ++#define TL_MR3220V2_GPIO_BTN_RESET	11

static struct gpio_keys_button tl_mr3220v2_gpio_keys[] __initdata = {
{
--.desc = "WPS",
++.desc = "reset",
.type = EV_KEY,
--.code = KEY_WPS_BUTTON,
++.code = KEY_RESTART,
.debounce_interval = TL_WR741NDV4_KEYS_DEBOUNCE_INTERVAL,
--.gpio = TL_MR3220V2_GPIO_BTN_WPS,
++.gpio = TL_MR3220V2_GPIO_BTN_RESET,
.active_low = 0,
}, {
.desc = "WIFI button",
.type = EV_KEY,
.code = KEY_RFKILL,
.debounce_interval = TL_WR741NDV4_KEYS_DEBOUNCE_INTERVAL,
.gpio = TL_MR3220V2_GPIO_BTN_WIFI,
.active_low = 0,
}
};

@openwrt-bot
Copy link
Author

adrianschmutzler:

User guide tells me it's a combined WPS/reset button (and labelled as such).

So, it's a moot question whether it should be WPS or reset in OpenWrt.

But, anyway, 18.06 is EOL now, and old TL-MR3220V2 isn't ported to ath79. So, I don't think we should change the button's behavior in its final days after already having 19.07.5 now, and having no support in subsequent release (it's 4/32 as well) at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant