Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3433 - Time-based firewall rules do not handle daylight savings properly #8360

Closed
openwrt-bot opened this issue Nov 4, 2020 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

mactenchi:

From https://forum.openwrt.org/t/firewall-parental-controls/24813

After recent switch from Daylight to Standard time, firewall rules are off by one hour.

Raspberry Pi 4 Model B Rev 1.1

OpenWrt SNAPSHOT r14459-96586ad8ca / LuCI Master git-20.254.65894-a314b59

  • create a firewall rule with time component (start_time, stop_time)
  • after daylight savings change, start_time and stop_time still behave as if time had not changed (off by one hour)
@openwrt-bot
Copy link
Author

jow-:

If at all, then this is likely an upstream bug. I don't think this will ever be fixed though, the times are basically translated once and then set forever.

There is no infrastructure at all in the kernel that follows all the DST nuisances as that would require having something equivalent to the tzdata database in kernelspace.

Can't really think of a good solution to this at all. Maybe setup cron jobs that restart the firewall shortly after the DST transition dates (which might be dynamic for your particular location) - that should force deleting and re-adding rules with a new local time.

@openwrt-bot
Copy link
Author

mactenchi:

Might I suggest disallowing time-based rules that use local time and always use UTC time? That would at least behave predictably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant