Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3421 - netifd: tries to claim VAP device before it's created #8291

Open
openwrt-bot opened this issue Nov 1, 2020 · 2 comments
Open

FS#3421 - netifd: tries to claim VAP device before it's created #8291

openwrt-bot opened this issue Nov 1, 2020 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

marcin1j:

This is obviously a general issue but the problem was reported on Netgear RT6220. There are two 5 GHz (radio1, non-DFS channel) VAPs and five VAPs in total. Netifd debug log is attached.

When netifd tries to claim second 5 GHz VAP (wl1-gst) it fails with error message:

device_claim(447): claim Network device wl1-gst failed: -1

It seems that the second VAP had not been (yet) created by hostapd when netifd tried to claim it as if it lacked a proper synchronization with hostapd.

As a result:

  • wl1-gst device is never added as bridge member,
  • it permanently stays in "down" state:
# ubus call network.device status '{ "name": "wl1-gst" }' { "external": true, "present": true, "type": "Network device", "up": false, "carrier": true, "statistics": { ... } } * the second 5 GHz VAP is pretty much useless.

There's no easy way to workaround this since each wifi reload command triggers the same routine.

Is it possible to fix netifd without a major rewrite? It seems that to consider each VAP ready as soon as hostapd is started, which is obviously not the case.

The problem was originally reported in FS#2698 but the workaround in #2848 treats only some symptoms. The root cause is still unaddressed.

@openwrt-bot
Copy link
Author

lynxis:

Can you check again?

The commit "system-linux: add retry for adding member devices to a bridge" should fixed it.

https://git.openwrt.org/?p=project/netifd.git;a=commit;h=3abe1fc87151fae570fc1232053c73d1a5505664

@openwrt-bot
Copy link
Author

marcin1j:

Netifd version 2020-11-30-42c48866-1 seems to be working just fine (tested on two ramips devices).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant