Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3397 - Firewall: weekdays option can't specify multiple days #8361

Closed
openwrt-bot opened this issue Oct 21, 2020 · 3 comments
Closed

FS#3397 - Firewall: weekdays option can't specify multiple days #8361

openwrt-bot opened this issue Oct 21, 2020 · 3 comments
Labels

Comments

@openwrt-bot
Copy link

ikazuhiro:

  • Device problem occurs on
    I-O Data WN-AC1167DGR, but probably device independent.

  • Software versions of OpenWrt/LEDE release, packages, etc.
    trunk, firewall-2020-09-05-8c2f9fad

  • Steps to reproduce

  1. Make a rule which contains weekdays option specifying more than one day.

/etc/config/firewall

config rule
option src 'lan'
option name 'block-test'
option dest 'wan'
list src_mac 'FF:FF:FF:FF:FF:FF'
option family 'ipv4'
option target 'REJECT'
option weekdays 'Sun Mon Tue'

  1. Run fw3 print | grep 'block-test' .
iptables -t filter -A zone_lan_forward -p tcp -m mac --mac-source FF:FF:FF:FF:FF:FF -m time --weekdays Mon --kerneltz -m comment --comment "!fw3: block-test" -j zone_wan_dest_REJECT iptables -t filter -A zone_lan_forward -p udp -m mac --mac-source FF:FF:FF:FF:FF:FF -m time --weekdays Mon --kerneltz -m comment --comment "!fw3: block-test" -j zone_wan_dest_REJECT

Only Monday is set as --weekdays option's argument.

@openwrt-bot
Copy link
Author

ikazuhiro:

Please see attached patch for firewall3.

@openwrt-bot
Copy link
Author

ikazuhiro:

Sorry, the above patch is incorrect. Here is correct one.

@openwrt-bot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant