Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3396 - fstools block insufficient target length #8257

Open
openwrt-bot opened this issue Oct 21, 2020 · 1 comment
Open

FS#3396 - fstools block insufficient target length #8257

openwrt-bot opened this issue Oct 21, 2020 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

mrjoel:

In testing a new setup using a current trunk build on a ClearFog Base device with two SSD drives, I ran into the issue where the LVM path name for my preferred volume naming was too long for the fstools handling.

In at least mount_action() and mount_device() a local char[32] is used which in my case ended up being insufficient when attempting to use paths such as "/dev/mapper/vgA_samplehostname-volnamesomething". For the time being I happen to be able to use the shorter version of "/dev/vgA_samplehostname/volnamesomething", but it should be considered to expand the full device name buffer to a larger size.

@openwrt-bot
Copy link
Author

mrjoel:

Of course my sample names don't line up (the "shorter version" as provided is still too long). In reality, I happen to be using something that is too long with the "mapper" path segment, but just short enough when not using it, something more like:

/dev/mapper/vgA_hostname/volnameXYZ
/dev/vgA_hostname/volnameXYZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant