Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3378 - uhttpd randomly returns "400 Bad request" #8716

Closed
openwrt-bot opened this issue Oct 11, 2020 · 1 comment
Closed

FS#3378 - uhttpd randomly returns "400 Bad request" #8716

openwrt-bot opened this issue Oct 11, 2020 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

bolvan:

In recent trunk uhttpd (2020-08-05-212f8364-1) sometimes return http error 400 Bad request

when cl->state==CLIENT_STATE_INIT
ustream_get_read_buf should read http request starting with method (GET,POST)
and ending with request body

sometimes it reads previous request body followed by current request (GET ...........)
it looks like

<some_json_date>GET /cgi-bin/luci/....

then this block is passed to client_init_cb and client_parse_request
client_parse_request return CLIENT_STATE_DONE
and it triggers uh_header_error(cl, 400, "Bad Request");

If I replace uhttpd binary with the one taken from 19.07 problem disappears (had to ln one .so to make it work)

@openwrt-bot
Copy link
Author

jow-:

Can you provide a reproducer for it? If you're able to trigger it with your browser then a .har archive of the HTTP requests made would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant