Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3356 - https-dns-proxy: Luci interface breaks the configuration if a custom server is used #8210

Open
openwrt-bot opened this issue Sep 22, 2020 · 0 comments
Labels
core packages pull request/issue for core (in-tree) packages flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release

Comments

@openwrt-bot
Copy link

Nowaker:

When you edit /etc/config/https-dns-proxy and set a custom server, not known to Luci HTML interface, the Luci UI at /cgi-bin/luci/admin/services/https-dns-proxy will display "CIRA Canadian Shield (Family)" as the selected resolver. This, by itself is not a problem yet, as the Proxy will function as expected.

However, the moment one makes any changes in the UI, e.g. changing listen port, /etc/config/https-dns-proxy will get rewritten and an actual resolver for CIRA Canadian Shield (Family) will be used.

Luci interface for HTTPS DNS Proxy should:

  1. Bare minimum: indicate a custom resolver is used, and not lose the resolver after making changes to listen port and other stuff.
  2. Nice to have: Allow a user to define a custom resolver in the UI - by specifying resolver_url, bootstrap_dns, user and group properties

The problem applies on any device as it's not device-specific.

Reproduction instruction:

  1. Edit /etc/config/https-dns-proxy and make it look like this:
config main 'config'
        option update_dnsmasq_config '-'

config https-dns-proxy
        option listen_addr '127.0.0.1'
        option listen_port '5054'
        option user 'nobody'
        option group 'nogroup'
        option bootstrap_dns '1.1.1.1,1.0.0.1,2606:4700:4700::1111,2606:4700:4700::1001'
        option resolver_url 'https://1.1.1.1/dns-query'
  1. Go to http://192.168.10.1/cgi-bin/luci/admin/services/https-dns-proxy and observe "CIRA Canadian Shield (Family)" as the selected resolver.
  2. Change listen port and click Save & Apply.
  3. Observe /etc/config/https-dns-proxy lose resolver_url setting.
@aparcar aparcar added release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release core packages pull request/issue for core (in-tree) packages labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release
Projects
None yet
Development

No branches or pull requests

2 participants