Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3234 - 19.07.2 imagebuilder does not work with (detect) gcc 10.1 and FORCE=1 is not respected #8101

Closed
openwrt-bot opened this issue Jul 16, 2020 · 4 comments
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release toolchain pull request/issue with toolchain related changes

Comments

@openwrt-bot
Copy link

Naguz:

Imagebuilder is unable to detect gcc/g++ on my system running gcc 10.1 FORCE=1 makes no difference, and seems to be ignored.

[naguz@blaptop openwrt-imagebuilder-19.07.2]$ make image FORCE=1 PROFILE=tplink_archer-c7-v2 FILES=files/
Checking 'working-make'... ok.
Checking 'case-sensitive-fs'... ok.
Checking 'proper-umask'... ok.
Checking 'gcc'... failed.
Checking 'working-gcc'... ok.
Checking 'g++'... failed.
Checking 'working-g++'... ok.
Checking 'ncurses'... ok.
Checking 'perl-thread-queue'... ok.
Checking 'tar'... ok.
Checking 'find'... ok.
Checking 'bash'... ok.
Checking 'patch'... ok.
Checking 'diff'... ok.
Checking 'cp'... ok.
Checking 'seq'... ok.
Checking 'awk'... ok.
Checking 'grep'... ok.
Checking 'getopt'... ok.
Checking 'stat'... ok.
Checking 'unzip'... ok.
Checking 'bzip2'... ok.
Checking 'wget'... ok.
Checking 'perl'... ok.
Checking 'python3-cleanup'... ok.
Checking 'python'... ok.
Checking 'git'... ok.
Checking 'file'... ok.
Checking 'ldconfig-stub'... ok.

Build dependency: Please install the GNU C Compiler (gcc) 4.8 or later
Build dependency: Please install the GNU C++ Compiler (g++) 4.8 or later

Prerequisite check failed. Use FORCE=1 to override.
make[1]: *** [Makefile:87: staging_dir/host/.prereq-build] Error 1
make: *** [Makefile:197: image] Error 2
[gert@blad openwrt-imagebuilder-19.07.2]$

@openwrt-bot
Copy link
Author

ciscam:

I can reproduce with the imagebuilder from 18.06.8-ar71xx-tiny on Manjaro 20.1 5.4.64-1:

[openwrt-imagebuilder-18.06.8-ar71xx-tiny.Linux-x86_64]$ make image
Checking 'working-make'... ok.
Checking 'case-sensitive-fs'... ok.
Checking 'proper-umask'... ok.
Checking 'gcc'... failed.
Checking 'working-gcc'... ok.
Checking 'g++'... failed.
Checking 'working-g++'... ok.
Checking 'ncurses'... ok.
Checking 'perl-thread-queue'... ok.
Checking 'tar'... ok.
Checking 'find'... ok.
Checking 'bash'... ok.
Checking 'patch'... ok.
Checking 'diff'... ok.
Checking 'cp'... ok.
Checking 'seq'... ok.
Checking 'awk'... ok.
Checking 'grep'... ok.
Checking 'getopt'... ok.
Checking 'stat'... ok.
Checking 'unzip'... ok.
Checking 'bzip2'... ok.
Checking 'wget'... ok.
Checking 'perl'... ok.
Checking 'python3-cleanup'... ok.
Checking 'python'... ok.
Checking 'git'... ok.
Checking 'file'... ok.
Checking 'ldconfig-stub'... ok.

Build dependency: Please install the GNU C Compiler (gcc) 4.8 or later
Build dependency: Please install the GNU C++ Compiler (g++) 4.8 or later

Prerequisite check failed. Use FORCE=1 to override.
make[1]: *** [Makefile:84: staging_dir/host/.prereq-build] Error 1
make: *** [Makefile:193: image] Error 2

$ pacman -Qi gcc |grep Version
Version : 10.2.0-2
$ echo $PATH
/home/user/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
$ whereis gcc g++
gcc: /usr/bin/gcc /usr/lib/gcc /usr/share/man/man1/gcc.1.gz /usr/share/info/gcc.info.gz
g++: /usr/bin/g++ /usr/share/man/man1/g++.1.gz

@openwrt-bot
Copy link
Author

ciscam:

works perfectly after I deleted the gcc and g++ checks from ./include/prereq-build.mk

@openwrt-bot
Copy link
Author

5p0ng3b0b:

Adding extra check for gcc-10 and g++-10 fixed it.

include/prereq-build.mk
@@ -37,6 +37,7 @@
gcc7 --version | grep gcc,
gcc8 --version | grep gcc,
gcc9 --version | grep gcc, \

  •   gcc-10 --version | grep gcc, \
      gcc --version | grep -E 'Apple.(LLVM|clang)' ))
    

$(eval $(call TestHostCommand,working-gcc,
@@ -56,6 +57,7 @@
g++7 --version | grep g++,
g++8 --version | grep g++,
g++9 --version | grep g++, \

  •   g++-10 --version | grep g++, \
      g++ --version | grep -E 'Apple.(LLVM|clang)' ))
    

$(eval $(call TestHostCommand,working-g++, </code>

@aparcar aparcar added release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release toolchain pull request/issue with toolchain related changes labels Feb 22, 2022
@KanjiMonster
Copy link
Member

This was fixed with 66cbfee, included in 19.07.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release toolchain pull request/issue with toolchain related changes
Projects
None yet
Development

No branches or pull requests

3 participants