FS#3212 - fail to generate json overview image info with python3.6 #8096
Labels
Comments
|
Greybeard: This might be associated with FS#3227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zhanhb:
With commit 263f7e5, fail to generate json overview image info with python3.6.
$ python3 --versionPython 3.6.8
$ make V=sc -r json_overview_image_info
make[1]: Entering directory
/firmware' cd "/firmware"; git log --format=%h -1 toolchain > /firmware/tmp/.ver_check cmp -s /firmware/tmp/.ver_check /firmware/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/stamp/.ver_check || { \ rm -rf /firmware/build_dir/target-mips_24kc_musl /firmware/staging_dir/target-mips_24kc_musl /firmware/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl /firmware/build_dir/toolchain-mips_24kc_gcc-8.4.0_musl; \ mkdir -p /firmware/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/stamp; \ mv /firmware/tmp/.ver_check /firmware/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/stamp/.ver_check; \ } WORK_DIR=/firmware/build_dir/target-mips_24kc_musl/json_info_files /firmware/scripts/json_overview_image_info.py /firmware/bin/targets/ath79/nand/profiles.json Traceback (most recent call last): File "/firmware/scripts/json_overview_image_info.py", line 47, in <module> text=True, File "/usr/lib64/python3.6/subprocess.py", line 423, in run with Popen(*popenargs, **kwargs) as process: TypeError: __init__() got an unexpected keyword argument 'capture_output' make[1]: *** [/firmware/bin/targets/ath79/nand/profiles.json] Error 1 make[1]: Leaving directory/firmware'make: *** [json_overview_image_info] Error 2
Patch:
Work as expected with 3.6, not sure if this patch is working with other versions.
diff --git a/scripts/json_overview_image_info.py b/scripts/json_overview_image_info.pyindex 59d69df314..3dd8c9c353 100755
--- a/scripts/json_overview_image_info.py
+++ b/scripts/json_overview_image_info.py
@@ -2,7 +2,7 @@
from os import getenv, environ
from pathlib import Path
-from subprocess import run
+from subprocess import run, PIPE
from sys import argv
import json
@@ -41,10 +41,10 @@ output["default_packages"] = run(
f"target/linux/{output['target'].split('/')[0]}",
"val.DEFAULT_PACKAGES",
],
check=True,
env=environ.copy().update({"TOPDIR": Path().cwd()}),
).stdout.split()
if output:
The text was updated successfully, but these errors were encountered: