Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3202 - libnl_tiny: struct np_sock may be affected by Y2038 Problem #8029

Open
openwrt-bot opened this issue Jun 25, 2020 · 0 comments
Open
Labels
core packages pull request/issue for core (in-tree) packages flyspray

Comments

@openwrt-bot
Copy link

quasi-mod:

Supply the following if possible:

  • Device problem occurs on
  • Software versions of OpenWrt/LEDE release, packages, etc.
  • Steps to reproduce

libnl_tiny stores time() value to sk->s_seq_expect and sk->s_seq_next (struct np_sock sk) in socket.c.
Struct members s_seq_expect and s_seq_next are both unsigned integer values, which I believe is to
overcome Y2038 Problem. Looking at git blame, this particular design choice has been made over 10 years ago.

Since many libraries and OS including gLibc and linux have already redefined time_t to signed 64 bit,
I think it is safe to redefine the members to uint64_t.

@aparcar aparcar added the core packages pull request/issue for core (in-tree) packages label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages flyspray
Projects
None yet
Development

No branches or pull requests

2 participants