Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3059 - DHCP options with spaces parsed incorrectly #7828

Open
openwrt-bot opened this issue May 2, 2020 · 3 comments
Open

FS#3059 - DHCP options with spaces parsed incorrectly #7828

openwrt-bot opened this issue May 2, 2020 · 3 comments
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release

Comments

@openwrt-bot
Copy link

jbrnd:

The following problem occurs on Archer C7 running 18.06, as well as an x86-64 VM running 19.07.02

I was attempting to PXE boot a Raspberry Pi, which requires setting DHCP option 43 to "Raspberry Pi Boot". I tried to do this by including

config tag 'rpipxe' list dhcp_option '43,"Raspberry Pi Boot"' list dhcp_option '66,"192.168.1.180"'

in /etc/config/dhcp. However, the code in /etc/init.d/dnsmasq does not correctly parse DHCP options with spaces, leading to the following in the dnsmasq config file under /var/tmp

dhcp-option=tag:rpipxe,66,192.168.1.180 dhcp-option=tag:rpipxe,43,Raspberry dhcp-option=tag:rpipxe,Pi dhcp-option=tag:rpipxe,Boot

The attached patch to /etc/init.d/dnsmasq fixes the problem (but may not necessarily be the right fix).

@openwrt-bot
Copy link
Author

jbrnd:

Correction: /var/tmp referred to above should be /var/etc.

@aparcar aparcar added the release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release label Feb 22, 2022
@jbrnd
Copy link

jbrnd commented May 1, 2023

This issue is still there in release 22.03.4. The patch that was attached to the original issue still works.

@jbrnd
Copy link

jbrnd commented Oct 15, 2023

Issue is still there in 23.05.0. The same patch still applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release
Projects
None yet
Development

No branches or pull requests

3 participants