Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2840 - ATH79: nonsense modules/no usb drivers for target 710Nv1 #7658

Closed
openwrt-bot opened this issue Feb 17, 2020 · 10 comments
Closed

FS#2840 - ATH79: nonsense modules/no usb drivers for target 710Nv1 #7658

openwrt-bot opened this issue Feb 17, 2020 · 10 comments
Labels

Comments

@openwrt-bot
Copy link

mgondium:

There are no default USB2 drivers selected for the TPLINK 710Nv1 target, and selecting them (kmod-usb2) does not create the modules (uhci-hcd).
Also, there are some nonsense modules selected by default (chipidea).

@openwrt-bot
Copy link
Author

adrianschmutzler:

Looks like you are right. kmod-usb-ledtrig-usbport is also nonsense as the device does not have an USB LED (at least none is configured).

Please submit a patch or GitHub Pull Request to fix this.

@openwrt-bot
Copy link
Author

mgondium:

Default config is correct for this target on ar7xxx/9xxx, where did ath79 change?

@openwrt-bot
Copy link
Author

adrianschmutzler:

Looks like it was wrong from the beginning:
fcc716e

@openwrt-bot
Copy link
Author

mgondium:

There are several instances where the chipidea module pops up.
I believe they may be wrong where the usb2 doesn't also show up (all the tplink devices), but I can't be sure.

generic.mk:
define Device/8dev_carambola2
DEVICE_PACKAGES := kmod-usb2 kmod-usb-chipidea2

generic.mk:
define Device/alfa-network_ap121f
DEVICE_PACKAGES := kmod-usb2 kmod-usb-chipidea2 kmod-usb-storage -swconfig

generic.mk:
define Device/embeddedwireless_dorin
DEVICE_PACKAGES := kmod-usb-chipidea2

generic.mk:
define Device/etactica_eg200
DEVICE_PACKAGES := kmod-usb-chipidea2 kmod-ledtrig-oneshot \

generic.mk:
define Device/glinet_gl-ar150
DEVICE_PACKAGES := kmod-usb-chipidea2

generic.mk:
define Device/pisen_ts-d084
DEVICE_PACKAGES := kmod-usb2 kmod-usb-chipidea2

generic.mk:
define Device/pisen_wmm003n
DEVICE_PACKAGES := kmod-usb2 kmod-usb-chipidea2

generic-tp-link.mk:
define Device/tplink_tl-wr710n-v1
DEVICE_PACKAGES := kmod-usb-chipidea2 kmod-usb-ledtrig-usbport

tiny-tp-link.mk:
define Device/tplink_tl-mr10u
DEVICE_PACKAGES := kmod-usb-chipidea2

tiny-tp-link.mk:
define Device/tplink_tl-mr3020-v1
DEVICE_PACKAGES := kmod-usb-chipidea2 kmod-usb-ledtrig-usbport

tiny-tp-link.mk:
define Device/tplink_tl-mr3040-v2
DEVICE_PACKAGES := kmod-usb-chipidea2 kmod-usb-ledtrig-usbport

tiny-tp-link.mk:
define Device/tplink_tl-wr703n
DEVICE_PACKAGES := kmod-usb-chipidea2

For what I know is correct, this seems adequate:

/openwrt/target/linux/ath79/image/generic-tp-link.mk
@@ -512,7 +512,7 @@
SOC := ar9331
DEVICE_MODEL := TL-WR710N
DEVICE_VARIANT := v1

  • DEVICE_PACKAGES := kmod-usb-chipidea2 kmod-usb-ledtrig-usbport
  • DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport
    TPLINK_HWID := 0x07100001
    SUPPORTED_DEVICES += tl-wr710n
    endef

The ledtrig is not there in the ar7xxx/9xxx, but I guess it can be useful.

@openwrt-bot
Copy link
Author

pepe2k:

See: https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/dts/ar9330.dtsi#L108
kmod-usb-chipidea2 provides support for host and device modes and is correct here.

@openwrt-bot
Copy link
Author

mgondium:

@piotr Dymacz

"Here", you mean, the 710Nv1?

@openwrt-bot
Copy link
Author

pepe2k:

710N v1 is based on AR9331, so yes.

@openwrt-bot
Copy link
Author

mgondium:

Well color me surprised, you're absolutely right. I could swear it didn't work the last time I tested it with the default configuration.
I must have been thrown off by the lack of the usb2 module.
I guess all is good then, thanks!

@openwrt-bot
Copy link
Author

adrianschmutzler:

I'd still remove usb-ledtrig-support

@openwrt-bot
Copy link
Author

mgondium:

I think it's the led trigger for the usb port usage, like the netdev one.
I've never used it so I'm neutral on that.
But you know what people say about not-broken things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant