Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2784 - libubox: usock: poll_restart() broken, affects usock_inet_timeout(). #7590

Open
openwrt-bot opened this issue Jan 30, 2020 · 0 comments
Labels

Comments

@openwrt-bot
Copy link

hmh:

on libubox/usock.c:

poll_restart() is trying to use the return of poll() as if it were errno.

This renders the error paths in that function ineffective, and most likely result in errors being hidden. The function will spin around until it times out, and mask the real error.

This impacts the "happy eyeballs" code on usock_inet_timeout(), plus any other users of poll_restart().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant