Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2668 - no wifi on Buffalo WZR600DHP (aka buffalo,wzr-hp-ag300h) after commit 82a741c774dc1aa1e2c2e4b2e445bf #7474

Closed
openwrt-bot opened this issue Dec 11, 2019 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

russell:

Supply the following if possible:

  • Device problem occurs on

Buffalo WZR600DHP

  • Software versions of OpenWrt/LEDE release, packages, etc.

Starting with commit 82a741c, continuing current HEAD (487e063) ... see: https://patchwork.ozlabs.org/patch/1196298/

  • Steps to reproduce

Boot, owl-loader doesn't run, no radios or wifi interfaces are detected. It looks like maybe a dependency problem. From make menuconfig, search for owl-loader:

Symbol: DEFAULT_kmod-owl-loader [=y] Type : boolean Defined at tmp/.config-target.in:184764 Selected by: TARGET_ar71xx_nand_DEVICE_z1 [=n] && && TARGET_ar71xx_nand [=n] || TARGET_ath79_generic_DEVICE_buffalo_wzr-hp-ag300h [=y] && && TARGET_ath79_generic [=y] || TARGET_ath79_generic_DEVICE_dlink_dir-825-b1 [=n] && && TARGET_ath79_generic [=y] || TARGET_ath79_generic_DEVICE_dlink_dir-825-c1 [=n] && && TARGET_ath79_generic [=y] || TARGET_ath79_generic_DEVICE_dlink_dir-835-a1 [=n] && && TARGET_ath79_generic [=y] || TARGET_ath79_generic_DEVICE_netgear_wndr3700 [=n] && && TARGET_at │ ...

Symbol: MODULE_DEFAULT_kmod-owl-loader [=n]
Type : tristate
Defined at tmp/.config-target.in:184767
Depends on: TARGET_PER_DEVICE_ROOTFS [=n] && m && MODULES [=y]
Selects: PACKAGE_kmod-owl-loader
Selected by: TARGET_DEVICE_ar71xx_nand_DEVICE_z1 [=n] && TARGET_MULTI_PROFILE [=n] && TARGET_ar71xx_nand [=n] && TARGET_PER_DEVICE_ROOTFS [=n] || TARGET_DEVICE_ath79_generic_DEVICE_buffalo_wzr-hp-ag300h [=n] && TARGET_MULTI_PROFILE [=n] && TARGET_ath79_generic [=y] && TARGET_PER_DEVICE_ROOTFS [=n] || TARGET_DEVICE_ath79_generic_DEVICE_dlink_dir-825-b1 [=n] && TARGET_MULTI_PROFILE [=n] && TARGET_ath79_generic [=y] && TARGET_PER_DEVICE_ROOTFS [=n] || TARGET_DEVICE_ath79_generic_DEVICE_dlink_dir-825-c1 [=n] && TARGET_MULTI_PROFILE [=n] && TA │ ...

Symbol: PACKAGE_kmod-owl-loader [=PACKAGE_kmod-owl-loader]
Type : unknown
Selected by: MODULE_DEFAULT_kmod-owl-loader [=n] && TARGET_PER_DEVICE_ROOTFS [=n] && m && MODULES [=y]

@openwrt-bot
Copy link
Author

russell:

With the .config stub:

CONFIG_TARGET_ath79=y CONFIG_TARGET_ath79_generic=y CONFIG_TARGET_ath79_generic_DEVICE_buffalo_wzr-hp-ag300h=y

Try:

make defconfig ; grep owl .config

before and after reverting the problematic commit.

With the commit, I get:

CONFIG_DEFAULT_kmod-owl-loader=y

Without the commit, I get:

CONFIG_DEFAULT_kmod-owl-loader=y CONFIG_PACKAGE_kmod-owl-loader=y

@openwrt-bot
Copy link
Author

chunkeey:

See Hannu Nyman, he reported it earlier on github to the commit:

[[https://github.com/openwrt/openwrt/commit/82a741c774dc1aa1e2c2e4b2e445bf79158de1a1#commitcomment-36317041|WNDR3700v2 wifi works again with owl-loader.]]

"Apparently the move of the kmod definition from one place to another package caused something to remain in the semi-hidden package data cache in tmp (which data is not cleared by "make clean"). That confused menuconfig/defconfig. But after deleting tmp, the module is visible in menuconfig, and seems to get compiled as necessary."

so, no patch was needed, instead the configs and tmp had to be refreshed.

(@PCI_SUPPORT could be a bit overkill, but we want to make sure that if a device has AHB but not necessarily PCI_SUPPORT we can't build)

@openwrt-bot
Copy link
Author

ynezz:

so, no patch was needed, instead the configs and tmp had to be refreshed

Ahh, nice. I removed tmp during testing, so that explains it. I'm not able to reproduce the problem anymore, thanks for clarification.

@openwrt-bot
Copy link
Author

russell:

Fwiw, while I was trying to figure out what was going on, I did a dirclean (which does remove $TOPDIR/tmp) but I did not rebuild the .config from the stub before rebuilding the image and the problem persisted. Just now I did another dirclean, followed by a defconfig from a stub, followed by a build, and everything is better now. Thanks!

Another fwiw, if I checkout f141090, rm -rf $TOPDIR/tmp, copy my stub to .config and run make defconfig, and then compare the resulting $TOPDIR/tmp to what I get if I do the same thing (including rm'ing tmp in between) with 82a741c, I see the following difference in tmp/.config-package.in:

config PACKAGE_kmod-owl-loader tristate "kmod-owl-loader.... Owl loader for initializing Atheros PCI(e) Wifi chips" default y if DEFAULT_kmod-owl-loader default m if ALL||ALL_NONSHARED||ALL_KMODS + depends on PCI_SUPPORT||USB_SUPPORT||TARGET_ar71xx||TARGET_ath79||TARGET_ath25 + select PACKAGE_kmod-ath9k + depends on PCI_SUPPORT||TARGET_ar71xx||TARGET_ath79 + depends on PCI_SUPPORT||USB_SUPPORT||TARGET_ar71xx||TARGET_ath79 depends on PCI_SUPPORT + depends on !(PACKAGE_iw-full This is necessary for devices like the Cisco Meraki Z1.
  •            https://wireless.wiki.kernel.org/
    
  •            Felix Fietkau <nbd@nbd.name>
    

If I don't rm $TOPDIR/tmp in between, I see this diff instead:

- config PACKAGE_kmod-owl-loader - tristate "kmod-owl-loader.... Owl loader for initializing Atheros PCI(e) Wifi chips" - default y if DEFAULT_kmod-owl-loader - default m if ALL||ALL_NONSHARED||ALL_KMODS - depends on PCI_SUPPORT - help - Kernel module that helps to initialize certain Qualcomm - Atheros' PCI(e) Wifi chips, which have the init data - (which contains the PCI device ID for example) stored - together with the calibration data in the file system. - - This is necessary for devices like the Cisco Meraki Z1. - -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant