Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2660 - Please tune down cifsd to avoid OOM #7512

Closed
openwrt-bot opened this issue Dec 8, 2019 · 3 comments
Closed

FS#2660 - Please tune down cifsd to avoid OOM #7512

openwrt-bot opened this issue Dec 8, 2019 · 3 comments
Labels

Comments

@openwrt-bot
Copy link

patrakov:

Supply the following if possible:

  • Device problem occurs on: TP-Link Archer C7 v2
  • Software versions of OpenWrt/LEDE release, packages, etc.: OpenWRT 19.07-rc2, cifsd-tools - 2019-11-25-49d0c401-1, kmod-fs-cifsd - 4.14.156+2019-11-22-511ee7e8-1, luci-app-cifsd - git-19.332.23110-3e90684-1
  • Steps to reproduce: play a "heavy" video file (e.g. a BluRay rip) using VLC from an SMB share.

According to the documentation at https://github.com/namjaejeon/cifsd-tools/blob/master/Documentation/configuration.txt, cifsd has some buffers that are way too big for embedded devices. The template configuration supplied by luci-app-cifsd (?) does not take this into account, thus making it too easy to invoke the OOM killer by accident with the default settings.

In particular, I am worried about these parameters and their default values:

  • max open files: default 10000, not sure what would be the reasonable value for others.
  • smb2 max read: default 4 MB, I am quite happy with 65536 bytes.
  • smb2 max write, smb2 max trans: same.
  • cache read buffers, cache trans buffers: default yes, these need investigation whether it makes sense to default to "no".
@openwrt-bot
Copy link
Author

leonghui:

I encountered the same issue with WRT1900ACv2 (OpenWrt SNAPSHOT r11398).

Setting cache read buffers and cache trans buffers to "no" fixed this issue for my case.

@openwrt-bot
Copy link
Author

Andy2244:

Did not encounter those problems yet, but i can tighten some of the default parameters as suggested for the next update.

PS: Btw keep in mind not all maintainers check this issue board, so i prefer a github issue and a direct ping/cc.

@openwrt-bot
Copy link
Author

Andy2244:

oki added the suggestion as possible fix to #10751, upstream also confirmed those settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant