Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2447 - [block mount] add label as option identifier to fstab #6189

Closed
openwrt-bot opened this issue Aug 17, 2019 · 6 comments
Closed

FS#2447 - [block mount] add label as option identifier to fstab #6189

openwrt-bot opened this issue Aug 17, 2019 · 6 comments
Labels

Comments

@openwrt-bot
Copy link

n8v8R:

Whilst the swap section in fstab features label such is curiously not available for mounting other fs.

It would be handy to able to mount partitions by their label (identifier) and thus this feature suggestion.

@openwrt-bot
Copy link
Author

yousong:

/etc/config/fstab should already support "label" as an identifier for "mount" section

@openwrt-bot
Copy link
Author

n8v8R:

how should it support label when it does not? Can you point to the code where it is implemented?

Swap partition can be mounted with label but others not. Tried mounting with label via /etc/config/fstab and it does not work.

Additionally LuCI exhibits UUID and Label for swap but only UUID for anything else.

This is even with the master branch.

@openwrt-bot
Copy link
Author

yousong:

It's scattered in the fstools/block.c code. Last time I read it while working on other issues, a device can be identified by using uuid first, then label & mount target. I tried mounting a volume created with "mkfs.ext4 -L xx" with only "label" specified for it in /e/c/fstab, it worked.

Maybe more exact output from your environment can help. Like output of "block info", lines from dmesg, bits from /etc/config/fstab etc.

@openwrt-bot
Copy link
Author

n8v8R:

Maybe the code has changed since the bug been lodged three months ago. Just tested it again with a Master branch node and it works now, suddenly also LuCI exhibits the Label option.

@openwrt-bot
Copy link
Author

yousong:

I remembered blaming the code showed that it was implemented since the very begining. If you still got the error case scene, it's not bad to also post more details here. Maybe just for archive purposes, or it can be a bug that need to be backported.

@openwrt-bot
Copy link
Author

n8v8R:

It may require backporting/uplifting to 18.x | 19.x, as said just tested in Master, but that is for the developer(s) to decide. To me the uplifting process from Master to other branches in OpenWrt is an enigma and from conversations on Github it would appear that there are not guidelines in place and uplifting rests within the merit of the package maintainer/reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant