OpenWrt/LEDE Project

  • Status Closed
  • Percent Complete
    100%
  • Task Type Feature Request
  • Category Base system
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by n8v8R - 17.08.2019
Last edited by Adrian Schmutzler - 19.11.2019

FS#2447 - [block mount] add label as option identifier to fstab

Whilst the swap section in fstab features label such is curiously not available for mounting other fs.

It would be handy to able to mount partitions by their label (identifier) and thus this feature suggestion.

 


Closed by  Adrian Schmutzler
19.11.2019 23:42
Reason for closing:  Implemented
Additional comments about closing:  

Reporter says it's working now.

Project Manager
Yousong Zhou commented on 28.10.2019 14:22

/etc/config/fstab should already support “label” as an identifier for “mount” section

n8v8R commented on 16.11.2019 19:54

how should it support label when it does not? Can you point to the code where it is implemented?

Swap partition can be mounted with label but others not. Tried mounting with label via /etc/config/fstab and it does not work.

Additionally LuCI exhibits UUID and Label for swap but only UUID for anything else.

This is even with the master branch.

Project Manager
Yousong Zhou commented on 17.11.2019 03:53

It's scattered in the fstools/block.c code. Last time I read it while working on other issues, a device can be identified by using uuid first, then label & mount target. I tried mounting a volume created with "mkfs.ext4 -L xx" with only "label" specified for it in /e/c/fstab, it worked.

Maybe more exact output from your environment can help. Like output of "block info", lines from dmesg, bits from /etc/config/fstab etc.

n8v8R commented on 19.11.2019 17:02

Maybe the code has changed since the bug been lodged three months ago. Just tested it again with a Master branch node and it works now, suddenly also LuCI exhibits the Label option.

Project Manager
Yousong Zhou commented on 19.11.2019 23:52

I remembered blaming the code showed that it was implemented since the very begining. If you still got the error case scene, it's not bad to also post more details here. Maybe just for archive purposes, or it can be a bug that need to be backported.

n8v8R commented on 20.11.2019 01:32

It may require backporting/uplifting to 18.x | 19.x, as said just tested in Master, but that is for the developer(s) to decide. To me the uplifting process from Master to other branches in OpenWrt is an enigma and from conversations on Github it would appear that there are not guidelines in place and uplifting rests within the merit of the package maintainer/reviewer.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing