Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2430 - Broken sysupgrade path from ubnt-erx to ubiquiti_edgerouterx due to NAND platform checks #7497

Closed
openwrt-bot opened this issue Aug 7, 2019 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

0x5a17ed:

Openwrt stable release fails to upgrade to the latest snapshot build with the message

Invalid sysupgrade file.
Image check 'platform_check_image' failed.

Supply the following if possible:

@openwrt-bot
Copy link
Author

0x5a17ed:

I think setting trunk as "Reported version" would be more fitting. Unfortunately I can't change my own tasks.

@openwrt-bot
Copy link
Author

bjonglez:

I can reproduce this issue.

It would seem it is cause by this commit:

https://git.openwrt.org/2f2a319f82ec86e2008fd056987d74189d5c147b

Although it adds the old name "ubnt-erx" to SUPPORTED_DEVICES, so it should work.

On a 18.06.5 initramfs image:

root@OpenWrt:/tmp# cat /tmp/sysinfo/board_name ubnt-erx root@OpenWrt:/tmp# cat /tmp/sysinfo/model UBNT-ERX

@openwrt-bot
Copy link
Author

bjonglez:

Alright, sysupgrade fails in ''nand_do_platform_check'' because of this requirement of the sysupgrade image: https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/base-files/files/lib/upgrade/nand.sh;h=e7d7bf8d13ae43e330abefbc9c678707e6a03bc9;hb=HEAD#l294

3) TAR - archive has to include "sysupgrade-BOARD" directory with a non-empty "CONTROL" file (at this point its content isn't verified)

The new sysupgrade image has the new boardname in the tar file:

$ tar tf openwrt-ramips-mt7621-ubiquiti_edgerouterx-squashfs-sysupgrade.bin sysupgrade-ubiquiti_edgerouterx/ sysupgrade-ubiquiti_edgerouterx/CONTROL sysupgrade-ubiquiti_edgerouterx/kernel sysupgrade-ubiquiti_edgerouterx/root

So, it definitely can't work currently. I'm not sure if there's an easy way to fix this.

@openwrt-bot
Copy link
Author

ynezz:

I've just upgraded my ERX from 18.06.5 to 19.07.0-rc2 and then to snapshot.
I've just upgraded my ERX from 18.06.5 to snapshot with sysupgrade -F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant