Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2425 - procd: Hangs on shutdown in docker #7248

Closed
openwrt-bot opened this issue Aug 4, 2019 · 4 comments
Closed

FS#2425 - procd: Hangs on shutdown in docker #7248

openwrt-bot opened this issue Aug 4, 2019 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

mikma:

The problem occurs with current openwrtorg/rootfs:x86-64 image available on docker hub.

Software versions:
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='SNAPSHOT'
DISTRIB_REVISION='r10664-ba8aeb02ea'
DISTRIB_TARGET='x86/64'
DISTRIB_ARCH='x86_64'
DISTRIB_DESCRIPTION='OpenWrt SNAPSHOT r10664-ba8aeb02ea'
DISTRIB_TAINTS=''

procd - 2019-05-30-31f0765a-1

Steps to reproduce

docker run --rm -it --name procdtest openwrtorg/rootfs:x86-64

In other terminal run:

time docker stop -t 30 procdtest

Actual result: It takes 30 seconds to finish the action:
real 0m30,507s
user 0m0,037s
sys 0m0,020s

Expected result: The 30 second timeout shouldn't be reached.
real 0m3,762s
user 0m0,033s
sys 0m0,016s

@openwrt-bot
Copy link
Author

mikma:

The following link contains a patch which works on docker but needs to be adapted for running on both containers and on hardware (or VMs).

https://github.com/mikma/lxd-openwrt/blob/master/patches/procd-master/0003-docker-fix-problem-stopping-container.patch

@openwrt-bot
Copy link
Author

aparcar0:

I think I'm able to port that patch, please give me a few days.

@openwrt-bot
Copy link
Author

aparcar0:

Please try this patch locally https://patch-diff.githubusercontent.com/raw/aparcar/procd/pull/2.patch

@openwrt-bot
Copy link
Author

aparcar0:

I applied the patch and it seem to work just fine!

a@reboot:~/src/openwrt/procd$ time sudo docker stop -t 30 procdtest
procdtest

real 0m3,650s
user 0m0,042s
sys 0m0,031s

Will send the patch upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant