New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS#2281 - The Dnsmasq-full seems have problems when it was compiled without DHCP function #7187
Comments
PussAzuki: Anyone can help me? If my statement is not clear enough, I can talk about it in more detail. You don’t say anything makes me very worried. |
yousong: 2 things to note
I would suggest grepping out dhcp-related options at the end of config generation
diff --git a/package/network/services/dnsmasq/files/dnsmasq.init b/package/network/services/dnsmasq/files/dnsmasq.init
index 93a8f9a108..e35a8a7933 100644
--- a/package/network/services/dnsmasq/files/dnsmasq.init
+++ b/package/network/services/dnsmasq/files/dnsmasq.init
@@ -1027,6 +1027,11 @@ dnsmasq_start()
done
}
Sorry for the late reply, but no need to worry. It just takes time. |
PussAzuki: If dnsmasq-full was compiled with DHCPv4 function only, can this pass that? |
yousong: That falls into the same setting as with "dnsmasq" package. I think it should work. I think the real problem is that initscript does not take into consideration all the combinations of customizations for dnsmasq-full. The patch I provided above can only serve as a rough hack. To seriously tackle the issue, we need to check option by option while in the same time trying to not break existing configs |
PussAzuki: OK, I will wait for you. Thanks for listening to me. |
yousong: I cannot make promise. Been too busy these days, sorry. |
yousong: Hi, I just sent out a patch [1] for review. Please give it a try to see if it works for you. Thank you. |
PussAzuki: This setting in the script does not seem to be ignored: DHCPBOGUSHOSTNAMEFILE="/usr/share/dnsmasq/dhcpbogushostname.conf" |
PussAzuki: If you have enough time, I think we should adjust the order of the script content, even rewrite it.It looks a bit messy now. |
yousong:
Set dhcpbogushostname to 0, it will not be output.
No, I do not have such plan in the near future. If it's really that bad, someone will do. |
PussAzuki: Set dhcpbogushostname to 0, it will not be output. ---- |
yousong: Rewrite is not the solution to documentation being incomplete. That said, feel free to improve the code ;) |
PussAzuki: Set dhcpbogushostname to 0, it will not be output. |
yousong: Hi PussAzuki, I wish you well, I really do. No need to suffer or be driven crazy because of a piece of software ;) As said in the commit message, the change is mainly for providing a way out for users with such customized dnsmasq build, i.e. they should be able to run dnsmasq by customizing only uci config, no need to tinker with code part.
If you got better solution, note that we are all ears to hear it. |
PussAzuki: Yes, as you said, this is designed for high-customized players, but when I did a clean flash and then started the router after that, it didn’t react at all.... because the package odhcpd has taken the DHCP responsibility of dnsmasq-full. But by default this won't be written in the file and this can be a big problem... |
PussAzuki:
First,select the package dnsmasq-full but not select the option " Build with DHCP support", then save the .config and start compiling ,finally extract the installation file or firmware to install or flash,and now you will see the dnsmasq won't start even if you modify it in the /etc/config/dhcp file unless you manually change its startup script. The keyword should be dhcp-ignore-names ,dhcp-broadcast and dhcp-leasefile.According to the documentation, when I go to modify the dnsmasq setting in the /etc/config/dhcp file and delete its dhcp related settings, dnsmasq's dhcp function can be disabled, but it is not implemented in this way.I used odhcpd to serve as a dhcpv4 and dhcpv6 server and I think it's no need to keep dnsmasq's DHCP function.
The text was updated successfully, but these errors were encountered: