Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2241 - Regression for dnsmasq config option add_wan_fqdn #7126

Open
openwrt-bot opened this issue Apr 18, 2019 · 0 comments
Open

FS#2241 - Regression for dnsmasq config option add_wan_fqdn #7126

openwrt-bot opened this issue Apr 18, 2019 · 0 comments
Labels

Comments

@openwrt-bot
Copy link

philsauce:

When dnsmasq's init script is invoked via the boot process, the UCI config option add_wan_fqdn is no longer effective. The content of /tmp/hosts/dhcp. only contains:
# auto-generated config file from /etc/config/dhcp

If dnsmasq is restarted after the network is up, it works as expected.

This is caused by commit [[https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=ecd954d5302b2d135005ca68c206bb2d544b0bde|ecd954d5302b2d135005ca68c206bb2d544b0bde]], which adds some conditions to the service triggers, one being the ignore option must be disabled.
The add_wan_fqdn option only takes effect when the ignore option is enabled.

The commit message suggests the condition was added in reverse:

//if the value of the ignore option is set to 0, then the corresponding interface trigger is not installed. Otherwise, if the ignore option value is 1, then procd_add_interface_trigger is called which adds the interface trigger.//

I've confirmed that reversing the condition fixes the problem, and have attached a patch for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant