Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2209 - Inconsistent behaviour of HOST_CONFIGURE_CMD vs CONFIGURE_CMD #7053

Open
openwrt-bot opened this issue Mar 29, 2019 · 0 comments
Open
Labels

Comments

@openwrt-bot
Copy link

Andy2244:

Target checks via:
if [ -x $(CONFIGURE_CMD) ]; then
yet host does:
if [ -x configure ]; then

So trying to use this, will fail for the target, but not for the host.

CONFIGURE_CMD = ./buildtools/bin/waf configure
HOST_CONFIGURE_CMD = ./buildtools/bin/waf configure

This results in ./buildtools/bin/waf: binary operator expected for the target.

The check is flawed in both cases, the host does not check for the custom configure command and the target is doing a file check only, so you have to ensure the actual "configure" argument is first in the CONFIGURE_ARGS.
CONFIGURE_ARGS:=configure $(CONFIGURE_ARGS)

This is confusing and both cases should work similar and check for CONFIGURE_CMD and maybe we should add a CONFIGURE_CMD_ARGS variable, that can hold custom arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant