OpenWrt/LEDE Project

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Bug Report
  • Category Base system
  • Assigned To No-one
  • Operating System All
  • Severity High
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by Andy Walsh - 29.03.2019

FS#2209 - Inconsistent behaviour of HOST_CONFIGURE_CMD vs CONFIGURE_CMD

Target checks via:

if [ -x $(CONFIGURE_CMD) ]; then

yet host does:

if [ -x configure ]; then

So trying to use this, will fail for the target, but not for the host.

CONFIGURE_CMD = ./buildtools/bin/waf configure
HOST_CONFIGURE_CMD = ./buildtools/bin/waf configure

This results in

./buildtools/bin/waf: binary operator expected

for the target.

The check is flawed in both cases, the host does not check for the custom configure command and the target is doing a file check only, so you have to ensure the actual “configure” argument is first in the CONFIGURE_ARGS.

CONFIGURE_ARGS:=configure $(CONFIGURE_ARGS)

This is confusing and both cases should work similar and check for CONFIGURE_CMD and maybe we should add a CONFIGURE_CMD_ARGS variable, that can hold custom arguments.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing