New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS#2193 - netdev LED Trigger for pppoe-wan #7387
Comments
Reiver: Same issue here and as reported on mailing list [[http://lists.infradead.org/pipermail/openwrt-devel/2019-February/015740.html]]. Couldn't see where the suggested commits would break it, the ledtrig-netdev code is the essentially the same. It's almost as if the underlying device ID changes whilst device name doesn't? [LINK UP - LED OFF] cd /sys/devices/platform/gpio-leds/leds/bthomehubv5a:blue:broadband/cat device_namepppoa-wan echo pppoa-wan > device_name[LED ON] |
ahmar20: I have no idea what's going on and yes you captured the LED behaviour as it is. It won't turn on when link gets established but it gets turned off when the link gets disconnected which is very strange. Also I observed something else, if I set a netdev trigger for vpn interface tun0 then the trigger works fine for it. The problem is that it does not work for wan interface only. Netdev trigger does work for other interfaces though. |
ezplanet: I have the same issue on BtHomeHub5, however a "service led reload" has no effect. This is my internet LED configuration in /etc/config/system config led 'led_internet' |
Reiver: Per duplicate bug FS#2239, the commit (now upstream) causing the problem was https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=eea538204bb973d73d3bc3d38947d7f85214d486 removing the NETDEV_CHANGENAME handling to fix a refcnt leak. |
ezplanet: Alan, I tried to remove that patch (patchfile: target/linux/generic/backport-4.14/401-v5.2-leds-trigger-netdev-fix-refcnt-leak-on-interface-ren.patch) and rebuild, but the LED still fails to work as expected. Is there anything else I might have missed? |
ms: This change should fix the problem: |
ahmar16:
Hi there, I am having a little issue with
netdev
LED trigger for DSL based routers. The issue occurs when the pppoe-wan connection gets connected but the assigned LED doesn't light up and shows no activity either. I have two HH5As and one TP-Link TDW8980 and these devices are based on xrx200 chips.The issue is appearing in master/snapshots builds, either manually compiled from source or downloaded from downloads.openwrt.org. Also the issue appears on all of the devices mentioned above.
To reproduce you can disconnect the pppoe-wan connection and connect it again. Once connected the LED wouldn't light up but if you issue a
service led reload
command then LED starts working as it should.The text was updated successfully, but these errors were encountered: