Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2061 - Different names for the same targets, let's decide: ALFA-NX, ALFANX or alfa-nx ? #6977

Closed
openwrt-bot opened this issue Jan 17, 2019 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

guifipedro:

I'm doing a tool that helps for compilation (I'm working based on lede 17.01.4). [[https://gitlab.com/guifi-exo/temba/blob/master/20-devices.yml#L83-126|With these targets I had no problems, the name is the same everywhere. yay!]], but with alfa-nx yes, this name is not clear, depends where you find it the name is different

here is ALFA-NX

# dmesg | grep -i board [ 0.000000] MyLoader: sysp=b9c9f1a8, boardp=9b949905, parts=b9c9f188 [ 0.000000] Kernel command line: board=ALFA-NX console=ttyS0,115200 mtdparts=spi0.0:256k(u-boot)ro,64k(u-boot-env)ro,6144k(rootfs),1600k(kernel),64k(nvram),64k(art)ro,7744k@0x50000(firmware) rootfstype=squashfs,jffs2 noinitrd

here is ALFANX

make info | grep 'ALFANX' -A2

ALFANX:
ALFA Network N2/N5 board
Packages:

here is alfa-nx (the output target in compilation)

lede-imagebuilder-17.01.4-ar71xx-generic.Linux-x86_64/bin/targets/ar71xx/generic/lede-17.01.4-ar71xx-generic-alfa-nx-squashfs-sysupgrade.bin

Do you agree that the same name should be everywhere? I think it should be alfa-nx (as the other profiles are 100% lowercase)

I can solve this locally putting an if statement (doing an exception), but I think it is better to have good universal names everywhere.

@openwrt-bot
Copy link
Author

guifipedro:

(The board name to be different is not important)

I find that all these names are very similar here, and they are uppercase:

target/linux/ar71xx/image/legacy.mk

looks like you want the legacy devices to be uppercase, no problem, I will find a way to process this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant