Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2024 - sysupgrade silently does nothing in case of active swap on block device #6899

Open
openwrt-bot opened this issue Dec 24, 2018 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

reinerotto:

Trying sysupgrade on my ZBT WE1026, with SD-Card installed, and swap file active on it, silently does not succeed.

However, as I am using 'sysupgrade -v -n -f /tmp/some_pars.tar.gz /tmp/fw.bin'
the files from some_pars.tar.gz are applied to unmodified system, resulting in inconsistencies.

Doing swapoff before
sysupgrade fixed my problem.

sysupgrade should at least issue an error message, when it does not succeed.
As I suspect, that unsuccessful umount of my block device with swap-file open is the culprit.

@openwrt-bot
Copy link
Author

jow-:

I‘ve read the description multiple times and I am still not sure what the problem is. Can you please describe exactly what the problem is and which error messages you received?

@openwrt-bot
Copy link
Author

reinerotto:

In other words: Active swapfile (or any open file ?) prevents sysupgrade to flash new image.
Howver, the files in "... -f /tmp/some_pars.tar.gz..." were applied to the flash mem.
Which caused inconsistent content of flash mem.
No erorr messages to be seen, but system rebooted.

So, in fact two issues: sysupgrade may not succceed, without any error messages, but reboots.
However, although no successful flash of image, new files from "/tmp/some_pars.tar.gz" written to flash.
_non_atomic operation here, causing inconsistent content of flash.

@openwrt-bot
Copy link
Author

cvocvo:

Bumping this back up; I confirmed this is a problem here with some additional details: https://forum.openwrt.org/t/sysupgrade-aborted-with-return-code-256/36922/15

@openwrt-bot
Copy link
Author

cvocvo:

Also looks like Jeff has a patch submitted here that would fix the issue: https://forum.openwrt.org/t/sysupgrade-aborted-with-return-code-256/36922/16?u=cvocvo
https://patchwork.ozlabs.org/patch/1116473/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant