Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1970 - libubox: Parsing empty blob messages return an error #6865

Open
openwrt-bot opened this issue Nov 25, 2018 · 0 comments
Open

FS#1970 - libubox: Parsing empty blob messages return an error #6865

openwrt-bot opened this issue Nov 25, 2018 · 0 comments
Labels

Comments

@openwrt-bot
Copy link

AlbanBedel:

Since commit c83a84afbef (fix segfault when passed blobmsg attr is NULL) parsing an empty message, like when "{}" is passed as argument to ubus call, return an error, it was working just fine before this commit.

This mean that ubus methods with only optional arguments need to check that blob_len() doesn't return 0, which is annoying and might break various existing programs. At the very least blobmsg_parse() shouldn't error out when the blob length is 0, but it might also make sense to accept a NULL message as well, just don't segfault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant