OpenWrt/LEDE Project

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Base system
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by Hugo Almeida - 25.11.2018
Last edited by Christian Lamparter - 10.12.2018

FS#1969 - sha256sum out of date about ath10k-firmware-2018-10-10-d366b80d.tar.xz

Supply the following if possible:
 - "all", Device problem occurs on
 - "master", Software versions of OpenWrt/LEDE release, packages, etc.
 - "said below", Steps to reproduce
   
it sha256sum of ath10k-firmware-2018-10-10-d366b80d.tar.xz
which defined at [here][ref]
[ref]: https://github.com/openwrt/openwrt/blob/master/package/firmware/ath10k-firmware/Makefile#L13

that
6285b9f9aa5a541b8258750f36955a6b307903a87cedd842b73dbfdd2bef8986
is out of date, and should be
ec06f10e6b1d4f7a28366a893c8a73a000454c2f031fc747381a1fb8aa1e0846

i've checked many times from all mirrors (if it valid), list below:

from https://github.com/openwrt/openwrt/blob/master/scripts/download.pl#L260-L263
```
#push @mirrors, 'https://mirror1.openwrt.org';
push @mirrors, 'https://sources.lede-project.org';
push @mirrors, 'https://mirror2.openwrt.org/sources';
push @mirrors, 'https://downloads.openwrt.org/sources';
```

P.S

when `make download` dis match reach the limit times,
`make` will turn to `git checkout` mode as a backup.

but the backup wont working,
as a bug `https://dev.archive.openwrt.org/ticket/20529` said,
it will not invoke host's new version tar,
which the building is not begin.

"so `make download` need a newer tar to download that must download newer tar first",
if sha256sum of tar dis match and exists system's tar is old.

i mean it will trigger error "tar: unrecognized option '--sort=name'",
and the backup wont working as expected (backup).

okay, it seems all url downloading operation should route to hash (sha256sum or md5sum).
why "Automate QC"/CI, check all openwrt source tree to avoid hash dis match.


Closed by  Christian Lamparter
10.12.2018 07:30
Reason for closing:  Fixed
Additional comments about closing:  

Thank you for reporting the issue. Fixed in commit: https://git.o penwrt.org/?p=openwrt/openwrt.git;a=comm it;h=87af41d554c7c4a708b87a894336a674f32 0358c

Hugo Almeida commented on 25.11.2018 08:05
feedback

for this issue itself, even use `git checkout` mode,
it should update to ec06f10e6b1d4f7a28366a893c8a73a000454c2f031fc747381a1fb8aa1e0846

we can invoke it as simple as below.

```
./scripts/dl_github_archive.py --dl-dir=/tmp \
--url="https://github.com/kvalo/ath10k-firmware.git" \
--version="d366b80d41309531c0c98b26625f23e318f33e31" \
--subdir="ath10k-firmware-2018-10-10-d366b80d" \
--source="ath10k-firmware-2018-10-10-d366b80d.tar.xz" \
--hash="6285b9f9aa5a541b8258750f36955a6b307903a87cedd842b73dbfdd2bef8986"
```

result should notice a "Download from ... failed" and "Wrong hash ..." error

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing