Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1969 - sha256sum out of date about ath10k-firmware-2018-10-10-d366b80d.tar.xz #6880

Closed
openwrt-bot opened this issue Nov 25, 2018 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

openalmeida:

Supply the following if possible: - "all", Device problem occurs on - "master", Software versions of OpenWrt/LEDE release, packages, etc. - "said below", Steps to reproduce

it sha256sum of ath10k-firmware-2018-10-10-d366b80d.tar.xz
which defined at [here][ref]
[ref]: https://github.com/openwrt/openwrt/blob/master/package/firmware/ath10k-firmware/Makefile#L13

that
6285b9f9aa5a541b8258750f36955a6b307903a87cedd842b73dbfdd2bef8986
is out of date, and should be
ec06f10e6b1d4f7a28366a893c8a73a000454c2f031fc747381a1fb8aa1e0846

i've checked many times from all mirrors (if it valid), list below:

from https://github.com/openwrt/openwrt/blob/master/scripts/download.pl#L260-L263

#push @mirrors, 'https://mirror1.openwrt.org';
push @mirrors, 'https://sources.lede-project.org';
push @mirrors, 'https://mirror2.openwrt.org/sources';
push @mirrors, 'https://downloads.openwrt.org/sources';

P.S

when make download dis match reach the limit times,
make will turn to git checkout mode as a backup.

but the backup wont working,
as a bug https://dev.archive.openwrt.org/ticket/20529 said,
it will not invoke host's new version tar,
which the building is not begin.

"so make download need a newer tar to download that must download newer tar first",
if sha256sum of tar dis match and exists system's tar is old.

i mean it will trigger error "tar: unrecognized option '--sort=name'",
and the backup wont working as expected (backup).

okay, it seems all url downloading operation should route to hash (sha256sum or md5sum).
why "Automate QC"/CI, check all openwrt source tree to avoid hash dis match.

@openwrt-bot
Copy link
Author

openalmeida:

feedback

for this issue itself, even use git checkout mode,
it should update to ec06f10e6b1d4f7a28366a893c8a73a000454c2f031fc747381a1fb8aa1e0846

we can invoke it as simple as below.

./scripts/dl_github_archive.py --dl-dir=/tmp \
--url="https://github.com/kvalo/ath10k-firmware.git" \
--version="d366b80d41309531c0c98b26625f23e318f33e31" \
--subdir="ath10k-firmware-2018-10-10-d366b80d" \
--source="ath10k-firmware-2018-10-10-d366b80d.tar.xz" \
--hash="6285b9f9aa5a541b8258750f36955a6b307903a87cedd842b73dbfdd2bef8986"

result should notice a "Download from ... failed" and "Wrong hash ..." error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant